Re: [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported

2018-01-21 Thread Dmitry Torokhov
On January 21, 2018 12:10:50 PM PST, ulrik.debie...@e2big.org wrote: >On Tue, Jan 16, 2018 at 03:07:13PM -0800, Dmitry Torokhov wrote: >Hi Dmitry, > >> >> On Sat, Jan 13, 2018 at 10:34:19AM +0800, Aaron Ma wrote: >> > Will your patch go to stable kernel? >> > If yes, that's fine. >> >> Hmm, it lo

Re: [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported

2018-01-21 Thread ulrik . debie-os
On Tue, Jan 16, 2018 at 03:07:13PM -0800, Dmitry Torokhov wrote: Hi Dmitry, > > On Sat, Jan 13, 2018 at 10:34:19AM +0800, Aaron Ma wrote: > > Will your patch go to stable kernel? > > If yes, that's fine. > > Hmm, it looks like we need this patch after all as we do have screwy > Lenovos with appa

Re: [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported

2018-01-16 Thread Dmitry Torokhov
On Sat, Jan 13, 2018 at 10:34:19AM +0800, Aaron Ma wrote: > Will your patch go to stable kernel? > If yes, that's fine. Hmm, it looks like we need this patch after all as we do have screwy Lenovos with apparently 0x01 devices reporting 0 buttons. From https://bugzilla.kernel.org/show_bug.cgi?id=19

Re: [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported

2018-01-12 Thread Aaron Ma
Will your patch go to stable kernel? If yes, that's fine.

Re: [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported

2018-01-12 Thread Dmitry Torokhov
Hi Aaron, On Fri, Jan 12, 2018 at 08:45:17PM +0800, Aaron Ma wrote: > Only this laptop had been confirmed is ALPS: 0102 – FF02 trackpoint, it > return 0 of extended button. > I saw the other device that returned 0, but don't have it now, so the ID > can not be checked. > > ThinkPad always have 3

Re: [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported

2018-01-12 Thread Aaron Ma
Only this laptop had been confirmed is ALPS: 0102 – FF02 trackpoint, it return 0 of extended button. I saw the other device that returned 0, but don't have it now, so the ID can not be checked. ThinkPad always have 3 buttons installed, I suggest always set 0x33 for button info when the button info

Re: [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported

2018-01-12 Thread Dmitry Torokhov
On Fri, Jan 12, 2018 at 02:46:58PM +0800, Aaron Ma wrote: > Lenovo introduced trackpoint compatible sticks with minimum PS/2 commands. > Some of these sticks with 3 buttons always return 0 when reading > extended button info, set it as 3 buttons to enable middle button. Does it only happen with ne

[PATCH] Input: trackpoint - force 3 buttons if 0 button is reported

2018-01-11 Thread Aaron Ma
Lenovo introduced trackpoint compatible sticks with minimum PS/2 commands. Some of these sticks with 3 buttons always return 0 when reading extended button info, set it as 3 buttons to enable middle button. Cc: sta...@vger.kernel.org Signed-off-by: Aaron Ma --- drivers/input/mouse/trackpoint.c |