Re: [PATCH] Input: pwm-beeper - defer pwm config if pwm can sleep

2016-05-13 Thread Manfred Schlaegl
On 2016-05-12 14:18, Thierry Reding wrote: > > I agree with Dmitry. Users of the PWM API should always assume that > calls to the PWM API might sleep. Conditionalizing on pwm_can_sleep() > isn't a good idea, since that function is scheduled to be removed. In > fact it's been returning true uncondi

Re: [PATCH] Input: pwm-beeper - defer pwm config if pwm can sleep

2016-05-12 Thread Thierry Reding
On Mon, Feb 22, 2016 at 11:46:39AM -0800, Dmitry Torokhov wrote: > On Wed, Feb 17, 2016 at 02:19:26PM +0100, Manfred Schlaegl wrote: > > If the pwm can sleep defer actions to it using a worker. > > A similar approach was used in leds-pwm (c971ff185) > > > > Trigger: > > On a Freescale i.MX53 based

Re: [PATCH] Input: pwm-beeper - defer pwm config if pwm can sleep

2016-03-30 Thread Manfred Schlaegl
Hello, Any more feedback on this? Just wanted to remember - this patch is still pending for integration. kindly regards, manfred

Re: [PATCH] Input: pwm-beeper - defer pwm config if pwm can sleep

2016-02-23 Thread Manfred Schlaegl
On 2016-02-22 20:46, Dmitry Torokhov wrote: > On Wed, Feb 17, 2016 at 02:19:26PM +0100, Manfred Schlaegl wrote: >> If the pwm can sleep defer actions to it using a worker. >> A similar approach was used in leds-pwm (c971ff185) >> >> Trigger: >> On a Freescale i.MX53 based board we ran into "BUG: sc

Re: [PATCH] Input: pwm-beeper - defer pwm config if pwm can sleep

2016-02-22 Thread Dmitry Torokhov
On Wed, Feb 17, 2016 at 02:19:26PM +0100, Manfred Schlaegl wrote: > If the pwm can sleep defer actions to it using a worker. > A similar approach was used in leds-pwm (c971ff185) > > Trigger: > On a Freescale i.MX53 based board we ran into "BUG: scheduling while > atomic" because input_inject_even

[PATCH] Input: pwm-beeper - defer pwm config if pwm can sleep

2016-02-17 Thread Manfred Schlaegl
If the pwm can sleep defer actions to it using a worker. A similar approach was used in leds-pwm (c971ff185) Trigger: On a Freescale i.MX53 based board we ran into "BUG: scheduling while atomic" because input_inject_event locks interrupts, but imx_pwm_config_v2 sleeps. Tested on Freescale i.MX53