Re: [PATCH] Input: cros_ec_keyb - avoid variable-length arrays on stack

2014-01-06 Thread Dmitry Torokhov
On Mon, Jan 06, 2014 at 10:57:14AM -0800, Doug Anderson wrote: > On Thu, Jan 2, 2014 at 4:25 PM, Luigi Semenzato > wrote: > > On Thu, Jan 2, 2014 at 11:48 AM, Dmitry Torokhov > > wrote: > >> Hi Doug, > >> > >> On Thu, Jan 02, 2014 at 09:40:44AM -0800, Doug Anderson wrote: > >>> Dmitry, > >>> > >

Re: [PATCH] Input: cros_ec_keyb - avoid variable-length arrays on stack

2014-01-06 Thread Doug Anderson
On Thu, Jan 2, 2014 at 4:25 PM, Luigi Semenzato wrote: > On Thu, Jan 2, 2014 at 11:48 AM, Dmitry Torokhov > wrote: >> Hi Doug, >> >> On Thu, Jan 02, 2014 at 09:40:44AM -0800, Doug Anderson wrote: >>> Dmitry, >>> >>> Thanks for cleaning up cros_eckeyb. :) I'm a little curious about >>> the motiv

Re: [PATCH] Input: cros_ec_keyb - avoid variable-length arrays on stack

2014-01-02 Thread Luigi Semenzato
On Thu, Jan 2, 2014 at 11:48 AM, Dmitry Torokhov wrote: > Hi Doug, > > On Thu, Jan 02, 2014 at 09:40:44AM -0800, Doug Anderson wrote: >> Dmitry, >> >> Thanks for cleaning up cros_eckeyb. :) I'm a little curious about >> the motivation here. I can't imagine a keyboard with all that many >> colum

Re: [PATCH] Input: cros_ec_keyb - avoid variable-length arrays on stack

2014-01-02 Thread Dmitry Torokhov
Hi Doug, On Thu, Jan 02, 2014 at 09:40:44AM -0800, Doug Anderson wrote: > Dmitry, > > Thanks for cleaning up cros_eckeyb. :) I'm a little curious about > the motivation here. I can't imagine a keyboard with all that many > columns (ours has 13), so it's really not taking a whole lot off of > t

Re: [PATCH] Input: cros_ec_keyb - avoid variable-length arrays on stack

2014-01-02 Thread Doug Anderson
Dmitry, Thanks for cleaning up cros_eckeyb. :) I'm a little curious about the motivation here. I can't imagine a keyboard with all that many columns (ours has 13), so it's really not taking a whole lot off of the stack. Are you trying to make some sort of automated checker happy, or just gener

[PATCH] Input: cros_ec_keyb - avoid variable-length arrays on stack

2013-12-31 Thread Dmitry Torokhov
Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/cros_ec_keyb.c | 80 --- 1 file changed, 45 insertions(+), 35 deletions(-) diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c index d44c5d4..03cb960 100644 --- a/dri