Re: [PATCH] IPC: fix error case when idr-cache is empty in ipcget()

2007-10-15 Thread Andrew Morton
On Thu, 11 Oct 2007 09:32:22 +0200 Pierre Peiffer <[EMAIL PROTECTED]> wrote: > @@ -373,7 +376,7 @@ int ipcget_public(struct ipc_namespace * > struct kern_ipc_perm *ipcp; > int flg = params->flg; > int err; > - > +retry: > err = idr_pre_get(&ids->ipcs_idr, GFP_KERNEL); > >

[PATCH] IPC: fix error case when idr-cache is empty in ipcget()

2007-10-11 Thread Pierre Peiffer
I resend this patch, by taking into account Nadia's remarks. With the use of idr to store the ipc, the case where the idr cache is empty, when idr_get_new is called (this may happen even if we call idr_pre_get() before), is not well handled: it lets semget()/shmget()/msgget() return ENOSPC when th

Re: [PATCH] IPC: fix error case when idr-cache is empty in ipcget()

2007-10-10 Thread Nadia Derbey
Pierre Peiffer wrote: With the use of idr to store the ipc, the case where the idr cache is empty, when idr_get_new is called (this may happen even if we call idr_pre_get() before), is not well handled: it lets semget()/shmget()/msgget() return ENOSPC when this cache is empty, what 1. does not re

[PATCH] IPC: fix error case when idr-cache is empty in ipcget()

2007-10-10 Thread Pierre Peiffer
With the use of idr to store the ipc, the case where the idr cache is empty, when idr_get_new is called (this may happen even if we call idr_pre_get() before), is not well handled: it lets semget()/shmget()/msgget() return ENOSPC when this cache is empty, what 1. does not reflect the facts and 2. d