Re: Re: [PATCH] IB/sa: Fix memleak in ib_nl_make_request

2020-12-27 Thread dinghao . liu
> On Sun, Dec 20, 2020 at 04:13:14PM +0800, Dinghao Liu wrote: > > When rdma_nl_multicast() fails, skb should be freed > > just like when ibnl_put_msg() fails. > > It is not so simple as you wrote in the description. > > There are no other places in the linux kernel that free > SKBs after netlink

Re: [PATCH] IB/sa: Fix memleak in ib_nl_make_request

2020-12-26 Thread Leon Romanovsky
On Sun, Dec 20, 2020 at 04:13:14PM +0800, Dinghao Liu wrote: > When rdma_nl_multicast() fails, skb should be freed > just like when ibnl_put_msg() fails. It is not so simple as you wrote in the description. There are no other places in the linux kernel that free SKBs after netlink_multicast() fai

[PATCH] IB/sa: Fix memleak in ib_nl_make_request

2020-12-20 Thread Dinghao Liu
When rdma_nl_multicast() fails, skb should be freed just like when ibnl_put_msg() fails. Signed-off-by: Dinghao Liu --- drivers/infiniband/core/sa_query.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/core/sa_query.c b/drivers/infiniband/core/sa_query