Re: [PATCH] HID: roccat: Remove use of the "exist" field

2016-08-29 Thread Silvan Jegen
Hi Benjamin Thanks for the review! On Mon, Aug 29, 2016 at 12:15 PM, Benjamin Tissoires wrote: > Hi Silvan, > > On Aug 21 2016 or thereabouts, Silvan Jegen wrote: >> The "exist" field is only checked when "roccat_open" has already been >> called or when we have made sure that the corresponding r

Re: [PATCH] HID: roccat: Remove use of the "exist" field

2016-08-29 Thread Benjamin Tissoires
Hi Silvan, On Aug 21 2016 or thereabouts, Silvan Jegen wrote: > The "exist" field is only checked when "roccat_open" has already been > called or when we have made sure that the corresponding roccat_device is > not NULL. Since the value of the "open" field has been increased by the > "roccat_open"

[PATCH] HID: roccat: Remove use of the "exist" field

2016-08-21 Thread Silvan Jegen
The "exist" field is only checked when "roccat_open" has already been called or when we have made sure that the corresponding roccat_device is not NULL. Since the value of the "open" field has been increased by the "roccat_open" call, instead of checking "exist" we can just check if "open" is equal