Re: [PATCH] HID: mcp2221: Fix GPIO output handling

2020-11-05 Thread Jiri Kosina
On Wed, 4 Nov 2020, Lars Povlsen wrote: > The mcp2221 driver GPIO output handling has has several issues. > > * A wrong value is used for the GPIO direction. > > * Wrong offsets are calculated for some GPIO set value/set direction > operations, when offset is larger than 0. > > This has been

Re: [PATCH] HID: mcp2221: Fix GPIO output handling

2020-11-04 Thread rishi gupta
On Thu, Nov 5, 2020 at 3:32 AM Lars Povlsen wrote: > > The mcp2221 driver GPIO output handling has has several issues. > > * A wrong value is used for the GPIO direction. > > * Wrong offsets are calculated for some GPIO set value/set direction > operations, when offset is larger than 0. > > This

[PATCH] HID: mcp2221: Fix GPIO output handling

2020-11-04 Thread Lars Povlsen
The mcp2221 driver GPIO output handling has has several issues. * A wrong value is used for the GPIO direction. * Wrong offsets are calculated for some GPIO set value/set direction operations, when offset is larger than 0. This has been fixed by introducing proper manifest constants for the di