Re: [PATCH] HID: add ThingM blink(1) USB LED support

2013-01-21 Thread Vivien Didelot
Hi, I wrote: > Should I keep the Kconfig macro CONFIG_BLINK1 or CONFIG_THINGM_BLINK1 > sounds better? CONFIG_HID_THINGM_BLINK1 is definitely more explicit. Here's a link to the v2: https://lkml.org/lkml/2013/1/21/435 Thanks, Vivien -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH] HID: add ThingM blink(1) USB LED support

2013-01-21 Thread Vivien Didelot
Hi Jiri, > hid-blink sounds too generic to me, taking into account that this is > not > 'generic HID blinking' framework, but rather a specific device driver > for > a particular device. > > So something like hid-thingm-blink sounds more reasonable to me. Ok, I'll name the file hid-thingm-blink1

Re: [PATCH] HID: add ThingM blink(1) USB LED support

2013-01-21 Thread Jiri Kosina
On Tue, 18 Dec 2012, Vivien Didelot wrote: > The ThingM blink(1) is an open source hardware USB RGB LED. It contains > an internal EEPROM, allowing to configure up to 12 light patterns. A > light pattern is a RGB color plus a fading time. This driver registers a > LED class instance with additiona

[PATCH] HID: add ThingM blink(1) USB LED support

2012-12-18 Thread Vivien Didelot
The ThingM blink(1) is an open source hardware USB RGB LED. It contains an internal EEPROM, allowing to configure up to 12 light patterns. A light pattern is a RGB color plus a fading time. This driver registers a LED class instance with additional sysfs attributes to support basic functions such a