Re: [PATCH] Generic compat_sys_fallocate

2007-09-29 Thread Geert Uytterhoeven
On Fri, 28 Sep 2007, Kyle McMartin wrote: > --- a/fs/compat.c > +++ b/fs/compat.c > @@ -2226,3 +2226,13 @@ asmlinkage long compat_sys_timerfd(int ufd, int > clockid, int flags, > } > > #endif /* CONFIG_TIMERFD */ > + > +asmlinkage long compat_sys_fallocate(int fd, int mode, > +

[PATCH] Generic compat_sys_fallocate

2007-09-28 Thread Kyle McMartin
Basically everyone is using the same sys32_fallocate. Delete a whole bunch of archdep code and move the compat wrapper to fs/compat.c Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> --- arch/mips/kernel/linux32.c|7 --- arch/mips/kernel/scall64-o32.S|2 +- arch/powerpc/ke

Re: [PATCH] Generic compat_sys_fallocate

2007-09-28 Thread Kyle McMartin
On Sat, Sep 29, 2007 at 07:06:10AM +0200, Heiko Carstens wrote: > > These are not identical... the least and most significant parts seem to get > passed in a different way on little and big endian machines. > Maybe it would be worth to have something like compat_merge_64() which does > the right t

Re: [PATCH] Generic compat_sys_fallocate

2007-09-28 Thread Heiko Carstens
On Fri, Sep 28, 2007 at 02:11:11PM -0400, Kyle McMartin wrote: > Basically everyone is using the same sys32_fallocate. Delete a whole bunch of > archdep code and move the compat wrapper to fs/compat.c > > Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> > --- a/arch/sparc64/kernel/sys_sparc32.c >

Re: [PATCH] Generic compat_sys_fallocate

2007-09-28 Thread Kyle McMartin
On Fri, Sep 28, 2007 at 09:01:37PM +0200, Arnd Bergmann wrote: > > This code assumes little-endian register ordering for 64 bit > arguments. AFAICS, this is wrong at aleast on mipseb and powerpc. > Yeah, you're right. I've an idea for how to fix this, will update patch soon. Cheers, Kyl

[PATCH] Generic compat_sys_fallocate

2007-09-28 Thread Kyle McMartin
Basically everyone is using the same sys32_fallocate. Delete a whole bunch of archdep code and move the compat wrapper to fs/compat.c Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> --- NOTE: Patch hunk in scall64-o32.S depends on a patch going in through Ralf's linux-mips tree. --- arch/mips/