Re: [PATCH] [PATCH] GenWQE: drop duplicate headers

2016-12-14 Thread Frank Haverkamp
Hi Geliang, > On 28 Nov 2016, at 15:15, Geliang Tang wrote: > > On Thu, Nov 24, 2016 at 01:51:57PM +0100, Frank Haverkamp wrote: >> Hi Geliang, >> >> thanks for the simplification. Did you find those by manual inspection, or >> did you use a tool? >> >> Acked-by: Frank Haverkamp > > Hi Fran

[PATCH] Re: [PATCH] GenWQE: drop duplicate headers

2016-11-28 Thread Geliang Tang
On Thu, Nov 24, 2016 at 01:51:57PM +0100, Frank Haverkamp wrote: > Hi Geliang, > > thanks for the simplification. Did you find those by manual inspection, or > did you use a tool? > > Acked-by: Frank Haverkamp Hi Frank, Thanks for your review. I found those duplicate headers by a simple scri

Re: [PATCH] GenWQE: drop duplicate headers

2016-11-28 Thread Frank Haverkamp
Hi Geliang, > On 23 Nov 2016, at 15:24, Geliang Tang wrote: > > Drop duplicate headers module.h and delay.h. > > Signed-off-by: Geliang Tang > --- > drivers/misc/genwqe/card_base.c | 1 - > drivers/misc/genwqe/card_ddcb.c | 1 - > drivers/misc/genwqe/card_utils.c | 1 - > 3 files changed, 3 de

[PATCH] GenWQE: drop duplicate headers

2016-11-23 Thread Geliang Tang
Drop duplicate headers module.h and delay.h. Signed-off-by: Geliang Tang --- drivers/misc/genwqe/card_base.c | 1 - drivers/misc/genwqe/card_ddcb.c | 1 - drivers/misc/genwqe/card_utils.c | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe