Re: [PATCH] Fix xoring of arch_get_random_long into crng->state array

2019-05-30 Thread Neil Horman
On Wed, May 29, 2019 at 11:12:01PM -0400, Theodore Ts'o wrote: > On Tue, Apr 02, 2019 at 06:00:25PM -0400, Neil Horman wrote: > > When _crng_extract is called, any arch that has a registered > > arch_get_random_long method, attempts to mix an unsigned long value into > > the crng->state buffer, it

Re: [PATCH] Fix xoring of arch_get_random_long into crng->state array

2019-05-29 Thread Theodore Ts'o
On Tue, Apr 02, 2019 at 06:00:25PM -0400, Neil Horman wrote: > When _crng_extract is called, any arch that has a registered > arch_get_random_long method, attempts to mix an unsigned long value into > the crng->state buffer, it only mixes in 32 of the 64 bits available, > because the state buffer i

Re: [PATCH] Fix xoring of arch_get_random_long into crng->state array

2019-05-29 Thread Neil Horman
On Wed, May 29, 2019 at 03:57:07PM +, David Laight wrote: > From: Neil Horman [mailto:nhor...@tuxdriver.com] > > Sent: 29 May 2019 16:52 > > On Wed, May 29, 2019 at 01:51:24PM +, David Laight wrote: > > > From: Neil Horman > > > > Sent: 29 May 2019 14:42 > > > > On Tue, Apr 02, 2019 at 06:0

RE: [PATCH] Fix xoring of arch_get_random_long into crng->state array

2019-05-29 Thread David Laight
From: Neil Horman [mailto:nhor...@tuxdriver.com] > Sent: 29 May 2019 16:52 > On Wed, May 29, 2019 at 01:51:24PM +, David Laight wrote: > > From: Neil Horman > > > Sent: 29 May 2019 14:42 > > > On Tue, Apr 02, 2019 at 06:00:25PM -0400, Neil Horman wrote: > > > > When _crng_extract is called, any

Re: [PATCH] Fix xoring of arch_get_random_long into crng->state array

2019-05-29 Thread Neil Horman
On Wed, May 29, 2019 at 01:51:24PM +, David Laight wrote: > From: Neil Horman > > Sent: 29 May 2019 14:42 > > On Tue, Apr 02, 2019 at 06:00:25PM -0400, Neil Horman wrote: > > > When _crng_extract is called, any arch that has a registered > > > arch_get_random_long method, attempts to mix an uns

RE: [PATCH] Fix xoring of arch_get_random_long into crng->state array

2019-05-29 Thread David Laight
From: Neil Horman > Sent: 29 May 2019 14:42 > On Tue, Apr 02, 2019 at 06:00:25PM -0400, Neil Horman wrote: > > When _crng_extract is called, any arch that has a registered > > arch_get_random_long method, attempts to mix an unsigned long value into > > the crng->state buffer, it only mixes in 32 of

Re: [PATCH] Fix xoring of arch_get_random_long into crng->state array

2019-05-29 Thread Neil Horman
On Tue, Apr 02, 2019 at 06:00:25PM -0400, Neil Horman wrote: > When _crng_extract is called, any arch that has a registered > arch_get_random_long method, attempts to mix an unsigned long value into > the crng->state buffer, it only mixes in 32 of the 64 bits available, > because the state buffer i

[PATCH] Fix xoring of arch_get_random_long into crng->state array

2019-04-02 Thread Neil Horman
When _crng_extract is called, any arch that has a registered arch_get_random_long method, attempts to mix an unsigned long value into the crng->state buffer, it only mixes in 32 of the 64 bits available, because the state buffer is an array of u32 values, even though 2 u32 are expected to be filled