Re: [PATCH] Fix sparsemem on Cell (take 3)

2007-01-07 Thread Tim Pepper
On 1/7/07, Dave Hansen <[EMAIL PROTECTED]> wrote: On Fri, 2007-01-05 at 22:52 -0600, John Rose wrote: > Could this break ia64, given that it uses memmap_init_zone()? You are right, I think it does. Boot tested OK on ia64 with this latest version of the patch. (forgot to click plain text on gm

Re: [PATCH] Fix sparsemem on Cell (take 3)

2007-01-07 Thread Arnd Bergmann
On Sunday 07 January 2007 09:58, Dave Hansen wrote: > The following patch fixes an oops experienced on the Cell architecture > when init-time functions, early_*(), are called at runtime.  It alters > the call paths to make sure that the callers explicitly say whether the > call is being made on beh

Re: [PATCH] Fix sparsemem on Cell (take 3)

2007-01-07 Thread Dave Hansen
On Fri, 2007-01-05 at 22:52 -0600, John Rose wrote: > > I dropped this on the floor over Christmas. This has had a few smoke > > tests on ppc64 and i386 and is ready for -mm. Against 2.6.20-rc2-mm1. > > Could this break ia64, given that it uses memmap_init_zone()? You are right, I think it does

Re: [PATCH] Fix sparsemem on Cell (take 3)

2007-01-05 Thread John Rose
> I dropped this on the floor over Christmas. This has had a few smoke > tests on ppc64 and i386 and is ready for -mm. Against 2.6.20-rc2-mm1. Could this break ia64, given that it uses memmap_init_zone()? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

[PATCH] Fix sparsemem on Cell (take 3)

2007-01-05 Thread Dave Hansen
I dropped this on the floor over Christmas. This has had a few smoke tests on ppc64 and i386 and is ready for -mm. Against 2.6.20-rc2-mm1. The following patch fixes an oops experienced on the Cell architecture when init-time functions, early_*(), are called at runtime. It alters the call paths

Re: [PATCH] Fix sparsemem on Cell

2006-12-19 Thread Dave Hansen
Pulling cbe... list off the cc because it is giving annoying 'too many recipients' warnings. On Tue, 2006-12-19 at 09:59 +0100, Arnd Bergmann wrote: > On Tuesday 19 December 2006 00:16, Dave Hansen wrote: > > How about an enum, or a pair of #defines? > > > > enum context > > { > > EARLY,

Re: [PATCH] Fix sparsemem on Cell

2006-12-19 Thread Arnd Bergmann
On Tuesday 19 December 2006 00:16, Dave Hansen wrote: > How about an enum, or a pair of #defines? > > enum context > { >         EARLY, >         HOTPLUG > }; Sounds good, but since this is in a global header file, it needs to be in an appropriate name space, like enum memmap_context { M

Re: [PATCH] Fix sparsemem on Cell

2006-12-18 Thread KAMEZAWA Hiroyuki
On Mon, 18 Dec 2006 15:16:20 -0800 Dave Hansen <[EMAIL PROTECTED]> wrote: > enum context > { > EARLY, > HOTPLUG > }; I like this :) Thanks, -Kame - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] Fix sparsemem on Cell

2006-12-18 Thread Dave Hansen
On Mon, 2006-12-18 at 23:54 +0100, Arnd Bergmann wrote: > #ifndef __HAVE_ARCH_MEMMAP_INIT > #define memmap_init(size, nid, zone, start_pfn) \ > - memmap_init_zone((size), (nid), (zone), (start_pfn)) > + memmap_init_zone((size), (nid), (zone), (start_pfn), 1) > #endif This is what I was

Re: [PATCH] Fix sparsemem on Cell

2006-12-18 Thread Arnd Bergmann
On Saturday 16 December 2006 09:03, KAMEZAWA Hiroyuki wrote: > @@ -273,10 +284,13 @@ > if (ret) > goto error; > } > +   atomic_inc(&memory_hotadd_count); >   > /* call arch's memory hotadd */ > ret = arch_add_memory(nid, start, siz

Re: [PATCH] Fix sparsemem on Cell

2006-12-18 Thread Christoph Hellwig
On Mon, Dec 18, 2006 at 01:13:57PM -0800, Dave Hansen wrote: > On Sat, 2006-12-16 at 17:03 +0900, KAMEZAWA Hiroyuki wrote: > > /* add this memory to iomem resource */ > > static struct resource *register_memory_resource(u64 start, u64 size) > > { > > @@ -273,10 +284,13 @@ > > if (ret

Re: [PATCH] Fix sparsemem on Cell

2006-12-18 Thread Dave Hansen
On Sat, 2006-12-16 at 17:03 +0900, KAMEZAWA Hiroyuki wrote: > /* add this memory to iomem resource */ > static struct resource *register_memory_resource(u64 start, u64 size) > { > @@ -273,10 +284,13 @@ > if (ret) > goto error; > } > + atomic_inc(&mem

Re: [PATCH] Fix sparsemem on Cell

2006-12-17 Thread Arnd Bergmann
On Friday 15 December 2006 18:14, Dave Hansen wrote: > +   if (system_state >= SYSTEM_RUNNING) > +   return 1; > + if (!early_pfn_valid(pfn)) > + return 0; > + if (!early_pfn_in_nid(pfn, nid)) > + return 0; I haven't tried it, but I assume th

Re: [PATCH] Fix sparsemem on Cell

2006-12-16 Thread KAMEZAWA Hiroyuki
On Fri, 15 Dec 2006 11:45:36 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > Perhaps if the function's role in the world was commented it would be clearer. > How about patch like this ? (this one is not tested.) Already-exisiting-more-generic-flag is available ? -Kame == include/linux/memory

Re: [PATCH] Fix sparsemem on Cell

2006-12-15 Thread Benjamin Herrenschmidt
> The only other assumption is that all memory-hotplug-time pages > given to memmap_init_zone() are valid and able to be onlined into > any any zone after the system is running. The "valid" part is > really just a question of whether or not a 'struct page' is there > for the pfn, and *not* wheth

Re: [PATCH] Fix sparsemem on Cell

2006-12-15 Thread Andrew Morton
On Fri, 15 Dec 2006 09:24:00 -0800 Dave Hansen <[EMAIL PROTECTED]> wrote: > > ... > > I think the comments added say it pretty well, but I'll repeat it here. > > This fix is pretty similar in concept to the one that Arnd posted > as a temporary workaround, but I've added a few comments explainin

Re: [PATCH] Fix sparsemem on Cell

2006-12-15 Thread Dave Hansen
On Fri, 2006-12-15 at 18:22 +0100, Michael Buesch wrote: > On Friday 15 December 2006 17:53, Dave Hansen wrote: > > lxc-dave/init/main.c |4 > > lxc-dave/mm/page_alloc.c | 28 +--- > > 2 files changed, 29 insertions(+), 3 deletions(-) > > > > diff -puN init/m

Re: [PATCH] Fix sparsemem on Cell

2006-12-15 Thread Andy Whitcroft
Dave Hansen wrote: I think the comments added say it pretty well, but I'll repeat it here. This fix is pretty similar in concept to the one that Arnd posted as a temporary workaround, but I've added a few comments explaining what the actual assumptions are, and improved it a wee little bit. The

Re: [PATCH] Fix sparsemem on Cell

2006-12-15 Thread Dave Hansen
On Fri, 2006-12-15 at 17:11 +, Andy Whitcroft wrote: > ie. that if hotplug is pushing this memory into a zone on a node it > really does know what its doing, and its putting it in the right place. > Obviously that code needs to be 'overlap' aware but thats ok for this > interface. I'm not su

Re: [PATCH] Fix sparsemem on Cell

2006-12-15 Thread Michael Buesch
On Friday 15 December 2006 17:53, Dave Hansen wrote: > > I think the comments added say it pretty well, but I'll repeat it here. > > This fix is pretty similar in concept to the one that Arnd posted > as a temporary workaround, but I've added a few comments explaining > what the actual assumption

[PATCH] Fix sparsemem on Cell

2006-12-15 Thread Dave Hansen
I think the comments added say it pretty well, but I'll repeat it here. This fix is pretty similar in concept to the one that Arnd posted as a temporary workaround, but I've added a few comments explaining what the actual assumptions are, and improved it a wee little bit. The end goal here is to

[PATCH] Fix sparsemem on Cell

2006-12-15 Thread Dave Hansen
I think the comments added say it pretty well, but I'll repeat it here. This fix is pretty similar in concept to the one that Arnd posted as a temporary workaround, but I've added a few comments explaining what the actual assumptions are, and improved it a wee little bit. The end goal here is to