Re: [PATCH] Fix refcount leak in tty_port.c

2013-07-24 Thread Greg KH
On Wed, Jul 24, 2013 at 10:11:47AM -0400, Peter Hurley wrote: > On 07/12/2013 10:04 AM, Peter Hurley wrote: > >On 07/12/2013 06:30 AM, Gustavo Padovan wrote: > >>Hi Gianluca, > >> > >>* Gianluca Anzolin [2013-07-09 10:35:35 +0200]: > >> > >>>Hello, > >>> > >>>In linux 3.10 in the file drivers/tty/

Re: [PATCH] Fix refcount leak in tty_port.c

2013-07-24 Thread Peter Hurley
On 07/12/2013 10:04 AM, Peter Hurley wrote: On 07/12/2013 06:30 AM, Gustavo Padovan wrote: Hi Gianluca, * Gianluca Anzolin [2013-07-09 10:35:35 +0200]: Hello, In linux 3.10 in the file drivers/tty/tty_port.c the function tty_port_tty_hangup may leak a tty reference: struct tty_str

Re: [PATCH] Fix refcount leak in tty_port.c

2013-07-12 Thread Greg KH
On Fri, Jul 12, 2013 at 11:47:33AM +0200, Gianluca Anzolin wrote: > Hello, > > I'm sorry to bother you again, I'm just pinging to see if you received the > patch or if it got lost in the noise. It fixes a regression introduced in git > commit aa27a094e2c2e > > I have another patch for rfcomm tty

Re: [PATCH] Fix refcount leak in tty_port.c

2013-07-12 Thread Peter Hurley
On 07/12/2013 06:30 AM, Gustavo Padovan wrote: Hi Gianluca, * Gianluca Anzolin [2013-07-09 10:35:35 +0200]: Hello, In linux 3.10 in the file drivers/tty/tty_port.c the function tty_port_tty_hangup may leak a tty reference: struct tty_struct *tty = tty_port_tty_get(port);

Re: [PATCH] Fix refcount leak in tty_port.c

2013-07-12 Thread Gustavo Padovan
Hi Gianluca, * Gianluca Anzolin [2013-07-09 10:35:35 +0200]: > Hello, > > In linux 3.10 in the file drivers/tty/tty_port.c the function > tty_port_tty_hangup may leak a tty reference: > > struct tty_struct *tty = tty_port_tty_get(port); > > if (tty && (!check_clocal || !C_CLOC

Re: [PATCH] Fix refcount leak in tty_port.c

2013-07-12 Thread Gianluca Anzolin
Hello, I'm sorry to bother you again, I'm just pinging to see if you received the patch or if it got lost in the noise. It fixes a regression introduced in git commit aa27a094e2c2e I have another patch for rfcomm tty waiting for this fix to get applied. Thank you, Gianluca On Tue, Jul 09, 2013

[PATCH] Fix refcount leak in tty_port.c

2013-07-09 Thread Gianluca Anzolin
Hello, In linux 3.10 in the file drivers/tty/tty_port.c the function tty_port_tty_hangup may leak a tty reference: struct tty_struct *tty = tty_port_tty_get(port); if (tty && (!check_clocal || !C_CLOCAL(tty))) { tty_hangup(tty); tty_kref_put(tty);