Re: [PATCH] Fix race between oom kill and task exit

2013-12-06 Thread Sameer Nanda
On Fri, Dec 6, 2013 at 7:19 AM, Oleg Nesterov wrote: > On 12/05, David Rientjes wrote: >> >> On Thu, 5 Dec 2013, Oleg Nesterov wrote: >> >> > > Your v2 series looks good and I suspect anybody trying them doesn't have >> > > additional reports of the infinite loop? Should they be marked for >> > >

Re: [PATCH] Fix race between oom kill and task exit

2013-12-06 Thread Oleg Nesterov
On 12/06, Oleg Nesterov wrote: > > And this is risky. For example, 1/4 depends on (at least) another patch > I sent in preparation for this change, commit 81907739851 > "kernel/fork.c:copy_process(): don't add the uninitialized > child to thread/task/pid lists", perhaps on something else. Hmm. not

Re: [PATCH] Fix race between oom kill and task exit

2013-12-06 Thread Oleg Nesterov
On 12/05, David Rientjes wrote: > > On Thu, 5 Dec 2013, Oleg Nesterov wrote: > > > > Your v2 series looks good and I suspect anybody trying them doesn't have > > > additional reports of the infinite loop? Should they be marked for > > > stable? > > > > Unlikely... > > > > I think the patch from Sa

Re: [PATCH] Fix race between oom kill and task exit

2013-12-05 Thread David Rientjes
On Thu, 5 Dec 2013, Oleg Nesterov wrote: > > > OK, I am going to send the initial fixes today. This means (I hope) > > > that we do not need this or Sameer's "[PATCH] mm, oom: Fix race when > > > selecting process to kill". > > > > Your v2 series looks good and I suspect anybody trying them doesn'

Re: [PATCH] Fix race between oom kill and task exit

2013-12-05 Thread Oleg Nesterov
On 12/04, David Rientjes wrote: > > On Mon, 2 Dec 2013, Oleg Nesterov wrote: > > > OK, I am going to send the initial fixes today. This means (I hope) > > that we do not need this or Sameer's "[PATCH] mm, oom: Fix race when > > selecting process to kill". > > Your v2 series looks good and I suspect

Re: [PATCH] Fix race between oom kill and task exit

2013-12-04 Thread David Rientjes
On Mon, 2 Dec 2013, Oleg Nesterov wrote: > OK, I am going to send the initial fixes today. This means (I hope) > that we do not need this or Sameer's "[PATCH] mm, oom: Fix race when > selecting process to kill". > Your v2 series looks good and I suspect anybody trying them doesn't have addition

Re: [PATCH] Fix race between oom kill and task exit

2013-12-02 Thread Oleg Nesterov
On 11/28, Oleg Nesterov wrote: > > On 11/28, Michal Hocko wrote: > > > > They are both trying to solve the same issue. Neither of them is > > optimal unfortunately. > > yes, but this one doesn't look right. > > > Oleg said he would look into this and I have seen > > some patches but didn't geto che

RE: [PATCH] Fix race between oom kill and task exit

2013-11-28 Thread Tu, Xiaobing
...@kvack.org; linux-kernel@vger.kernel.org; Peter Zijlstra; gre...@linuxfoundation.org; Tu, Xiaobing; azurIt; Sameer Nanda Subject: RE: [PATCH] Fix race between oom kill and task exit > From: Oleg Nesterov [mailto:o...@redhat.com] > Sent: Friday, November 29, 2013 2:39 AM > To: Michal H

RE: [PATCH] Fix race between oom kill and task exit

2013-11-28 Thread Ma, Xindong
.kernel.org; Peter Zijlstra; > gre...@linuxfoundation.org; Tu, Xiaobing; azurIt; Sameer Nanda > Subject: Re: [PATCH] Fix race between oom kill and task exit > > On 11/28, Michal Hocko wrote: > > > > They are both trying to solve the same issue. Neither of them is > > optim

Re: [PATCH] Fix race between oom kill and task exit

2013-11-28 Thread Oleg Nesterov
On 11/28, Michal Hocko wrote: > > They are both trying to solve the same issue. Neither of them is > optimal unfortunately. yes, but this one doesn't look right. > Oleg said he would look into this and I have seen > some patches but didn't geto check them. Only preparations so far. Oleg. -- To

Re: [PATCH] Fix race between oom kill and task exit

2013-11-28 Thread Oleg Nesterov
On 11/28, Ma, Xindong wrote: > > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -412,16 +412,6 @@ void oom_kill_process(struct task_struct *p, gfp_t > gfp_mask, int order, > static DEFINE_RATELIMIT_STATE(oom_rs, DEFAULT_RATELIMIT_INTERVAL, > DEFAUL

Re: [PATCH] Fix race between oom kill and task exit

2013-11-28 Thread Vladimir Murzin
On Thu, Nov 28, 2013 at 01:00:18PM +0100, Michal Hocko wrote: > [CCing Oleg - the thread started here: > https://lkml.org/lkml/2013/11/28/2] > > On Thu 28-11-13 09:41:40, William Dauchy wrote: > [...] > > However, I'm now wondering if this present patch is a replacement of > > Sameer Nanda's patch

Re: [PATCH] Fix race between oom kill and task exit

2013-11-28 Thread Michal Hocko
[CCing Oleg - the thread started here: https://lkml.org/lkml/2013/11/28/2] On Thu 28-11-13 09:41:40, William Dauchy wrote: [...] > However, I'm now wondering if this present patch is a replacement of > Sameer Nanda's patch or if this a complementary patch. They are both trying to solve the same i

Re: [PATCH] Fix race between oom kill and task exit

2013-11-28 Thread azurIt
> Od: Johannes Weiner > Komu: "Ma, Xindong" > Dátum: 28.11.2013 07:54 > Predmet: Re: [PATCH] Fix race between oom kill and task exit > > CC: "a...@linux-foundation.org" , "mho...@suse.cz" > , "rient...@google.com" , > &

Re: [PATCH] Fix race between oom kill and task exit

2013-11-28 Thread William Dauchy
Hi Johannes, On Thu, Nov 28, 2013 at 7:35 AM, Johannes Weiner wrote: > Cc William and azur who might have encountered this problem. Thank you for letting me know. Note that before this patch I saw the one from Sameer Nanda mm, oom: Fix race when selecting process to kill https://lkml.org/lkml/20

Re: [PATCH] Fix race between oom kill and task exit

2013-11-27 Thread Johannes Weiner
Cc William and azur who might have encountered this problem. On Thu, Nov 28, 2013 at 05:09:16AM +, Ma, Xindong wrote: > From: Leon Ma > Date: Thu, 28 Nov 2013 12:46:09 +0800 > Subject: [PATCH] Fix race between oom kill and task exit > > There is a race between oom kil

[PATCH] Fix race between oom kill and task exit

2013-11-27 Thread Ma, Xindong
From: Leon Ma Date: Thu, 28 Nov 2013 12:46:09 +0800 Subject: [PATCH] Fix race between oom kill and task exit There is a race between oom kill and task exit. Scenario is: TASK A TASK B TASK B is selected to oom kill in oom_kill_process() check PF_EXITING of TASK B