Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Jesper Juhl
On 12/11/2007, James Bottomley <[EMAIL PROTECTED]> wrote: > On Mon, 2007-11-12 at 01:13 +0100, Jesper Juhl wrote: > > On 12/11/2007, James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: > > > > From: Jesper Juhl <[EMAIL PROTECTED]> > > > > > > > > i

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread James Bottomley
On Sun, 2007-11-11 at 19:33 -0500, Douglas Gilbert wrote: > James Bottomley wrote: > > On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: > >> From: Jesper Juhl <[EMAIL PROTECTED]> > >> > >> in sas_get_phy_change_count(), the line > >>disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); > >> will

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread James Bottomley
On Mon, 2007-11-12 at 01:13 +0100, Jesper Juhl wrote: > On 12/11/2007, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: > > > From: Jesper Juhl <[EMAIL PROTECTED]> > > > > > > in sas_get_phy_change_count(), the line > > > disc_resp = alloc_s

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Douglas Gilbert
James Bottomley wrote: > On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: >> From: Jesper Juhl <[EMAIL PROTECTED]> >> >> in sas_get_phy_change_count(), the line >> disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); >> will allocate 56 bytes due to this define: >> #define DISCOVER_RESP_S

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Jesper Juhl
On 12/11/2007, James Bottomley <[EMAIL PROTECTED]> wrote: > On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: > > From: Jesper Juhl <[EMAIL PROTECTED]> > > > > in sas_get_phy_change_count(), the line > > disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); > > will allocate 56 bytes due to thi

Re: [PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread James Bottomley
On Mon, 2007-11-12 at 00:24 +0100, Jesper Juhl wrote: > From: Jesper Juhl <[EMAIL PROTECTED]> > > in sas_get_phy_change_count(), the line > disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); > will allocate 56 bytes due to this define: > #define DISCOVER_RESP_SIZE 56 > But, the struct is

[PATCH] Fix problem with size of allocation in libsas

2007-11-11 Thread Jesper Juhl
From: Jesper Juhl <[EMAIL PROTECTED]> in sas_get_phy_change_count(), the line disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE); will allocate 56 bytes due to this define: #define DISCOVER_RESP_SIZE 56 But, the struct is actually 60 bytes in size. So change the define to be