Re: [i2c] [PATCH] Fix i2c module parameter permissions for read/write

2007-11-06 Thread Jean Delvare
Hi Jon, On Sun, 4 Nov 2007 08:39:49 -0500, Jon Smirl wrote: > I figured out later by inserting printks into the driver that they > were being set from the command line, but without changing the > permissions there was no way to read them to verify. The permissions > should at least be set to 0444

Re: [i2c] [PATCH] Fix i2c module parameter permissions for read/write

2007-11-04 Thread Jon Smirl
On 11/4/07, Jean Delvare <[EMAIL PROTECTED]> wrote: > Hi John, > > On Sun, 4 Nov 2007 00:55:15 -0400, Jon Smirl wrote: > > The permissions of i2c module parameters were set to zero making the > > parameters invisible and unsettable from the kernel command line. This > > patch changes the permission

Re: [i2c] [PATCH] Fix i2c module parameter permissions for read/write

2007-11-04 Thread Jean Delvare
Hi John, On Sun, 4 Nov 2007 00:55:15 -0400, Jon Smirl wrote: > The permissions of i2c module parameters were set to zero making the > parameters invisible and unsettable from the kernel command line. This > patch changes the permissions to the standard 0644 read/write. These permissions have noth

[PATCH] Fix i2c module parameter permissions for read/write

2007-11-03 Thread Jon Smirl
The permissions of i2c module parameters were set to zero making the parameters invisible and unsettable from the kernel command line. This patch changes the permissions to the standard 0644 read/write. Signed-off-by: Jon Smirl <[EMAIL PROTECTED]> --- diff --git a/include/linux/i2c.h b/include/li