Re: [PATCH] Fix for possible null pointer dereference in auth.c

2014-05-17 Thread Trond Myklebust
On Sat, May 17, 2014 at 12:36 PM, Rickard Strandqvist wrote: > Hi > > I have made a new patch according Sergei specification. > I'll be happy to apply this patch once someone explains to me why we can't just remove that check for cred != NULL, however I'm not applying a patch purely in order to s

Re: [PATCH] Fix for possible null pointer dereference in auth.c

2014-05-17 Thread Rickard Strandqvist
Hi I have made a new patch according Sergei specification. But there remains Tronds question though. Best regards Rickard Strandqvist 2014-05-16 14:19 GMT+02:00 Sergei Shtylyov : > Hello. > > > On 16-05-2014 1:56, Rickard Strandqvist wrote: > >> There is otherwise a risk of a possible null poi

Re: [PATCH] Fix for possible null pointer dereference in auth.c

2014-05-16 Thread Sergei Shtylyov
Hello. On 16-05-2014 1:56, Rickard Strandqvist wrote: There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- net/sunrpc/auth.c | 10 +++--- 1 fil ändrad,

Re: [PATCH] Fix for possible null pointer dereference in auth.c

2014-05-15 Thread Rickard Strandqvist
Hi I do not know, I'm not an expert on this code. But since there before was a if (cred) someone must have thought this could happen. Best regards Rickard Strandqvist 2014-05-16 0:07 GMT+02:00 Trond Myklebust : > On Thu, May 15, 2014 at 5:56 PM, Rickard Strandqvist > wrote: >> There is otherwi

Re: [PATCH] Fix for possible null pointer dereference in auth.c

2014-05-15 Thread Trond Myklebust
On Thu, May 15, 2014 at 5:56 PM, Rickard Strandqvist wrote: > There is otherwise a risk of a possible null pointer dereference. > > Was largely found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > net/sunrpc/auth.c | 10 +++--- > 1 f

[PATCH] Fix for possible null pointer dereference in auth.c

2014-05-15 Thread Rickard Strandqvist
There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- net/sunrpc/auth.c | 10 +++--- 1 fil ändrad, 7 tillägg(+), 3 borttagningar(-) diff --git a/net/sunrpc/auth.c