Re: [PATCH] Fix floppy ioctl (which were broken in 2.4.0-test5)

2000-09-16 Thread Alain Knaff
> > >On Sat, 16 Sep 2000, Alain Knaff wrote: >> >> The following patch (against 2.4.0-test8) restores ioctl functionality, >> which has been broken in 2.4.0-test6-pre7: > >No. Th epatch breaks things. You cannot use "permission" at that point, >and the code was removed on purpose before. Nobody co

Re: [PATCH] Fix floppy ioctl (which were broken in 2.4.0-test5)

2000-09-16 Thread Alain Knaff
> > >On Sat, 16 Sep 2000, Alain Knaff wrote: > >> The following patch (against 2.4.0-test8) restores ioctl functionality, >> which has been broken in 2.4.0-test6-pre7: > >I would reserve "broken" for original state. What's wrong with "if you >want write permissions to be checked during open() - op

Re: [PATCH] Fix floppy ioctl (which were broken in 2.4.0-test5)

2000-09-16 Thread Andries Brouwer
On Sat, Sep 16, 2000 at 03:26:33PM +0200, Alain Knaff wrote: > The following patch (against 2.4.0-test8) restores ioctl functionality, > which has been broken in 2.4.0-test6-pre7: > + /* Allow ioctls if we have write-permissions even if read-only open. > + * Needed so that programs suc

Re: [PATCH] Fix floppy ioctl (which were broken in 2.4.0-test5)

2000-09-16 Thread Alexander Viro
On Sat, 16 Sep 2000, Alain Knaff wrote: > The following patch (against 2.4.0-test8) restores ioctl functionality, > which has been broken in 2.4.0-test6-pre7: I would reserve "broken" for original state. What's wrong with "if you want write permissions to be checked during open() - open the bl

Re: [PATCH] Fix floppy ioctl (which were broken in 2.4.0-test5)

2000-09-16 Thread Tigran Aivazian
Alain, Al Viro, myself and Linus broke this intentionally. Please read the comments we put in blkdev_get() in fs/block_dev.c and understand that this is a non-trivial issue - we had an interesting conversation about it - unfortunately all my mailfolders are gone (as a side-effect of truncate issu

[PATCH] Fix floppy ioctl (which were broken in 2.4.0-test5)

2000-09-16 Thread Alain Knaff
The following patch (against 2.4.0-test8) restores ioctl functionality, which has been broken in 2.4.0-test6-pre7: --- 2.4.0-test8/linux/drivers/block/floppy.cMon Sep 11 20:09:28 2000 +++ linux/drivers/block/floppy.cSat Sep 16 15:03:39 2000 @@ -3435,6 +3435,8 @@ static int fd_ioctl(s