Re: [PATCH] Fix early_ioremap on x86-64 II

2008-01-21 Thread Jeremy Fitzhardinge
Andi Kleen wrote: This patch changes all flushes in init_64.c to be __flush_tlb_all() and fixes the problem here. Hmm, I see new early crashes with that patch here in some cases unfortunately: PANIC: early exception 06 rip 10:8082df2d error 0 cr2 0 Pid: 0, comm: swapper Not tainte

Re: [PATCH] Fix early_ioremap on x86-64

2008-01-20 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > > Jeremy did suspect something about this change, as indicated in the > > changelog. But because the change was so finegrained, the bisection > > almost directly led to the fix. _That_ i think clearly demonstrates > > the power of bisection and finegra

Re: [PATCH] Fix early_ioremap on x86-64

2008-01-20 Thread Andi Kleen
On Sun, Jan 20, 2008 at 06:59:55PM +0100, Ingo Molnar wrote: > > Jeremy did suspect something about this change, as indicated in the > changelog. But because the change was so finegrained, the bisection > almost directly led to the fix. _That_ i think clearly demonstrates the > power of bisecti

Re: [PATCH] Fix early_ioremap on x86-64 II

2008-01-20 Thread Andi Kleen
> This patch changes all flushes in init_64.c to be __flush_tlb_all() > and fixes the problem here. Hmm, I see new early crashes with that patch here in some cases unfortunately: PANIC: early exception 06 rip 10:8082df2d error 0 cr2 0 Pid: 0, comm: swapper Not tainted 2.6.24-rc8-g7ada4254

Re: [PATCH] Fix early_ioremap on x86-64

2008-01-20 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > Fix early_ioremap on x86-64 > > [Venki, sorry for blaming PAT for this earlier. It was innocent.] > [Note the patch is on top of git-x86 + gbpages applied. I think there > will be an trivial reject without gbpages-direct applied first] > > I had ACPI

[PATCH] Fix early_ioremap on x86-64

2008-01-20 Thread Andi Kleen
Fix early_ioremap on x86-64 [Venki, sorry for blaming PAT for this earlier. It was innocent.] [Note the patch is on top of git-x86 + gbpages applied. I think there will be an trivial reject without gbpages-direct applied first] I had ACPI failures on several machines since a few days. Symptom was