Re: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Jeff Kirsher
On Wed, Aug 6, 2014 at 11:10 PM, Koehrer Mathias (ETAS/ESW5) wrote: > With the Intel 82527EI (driver: e1000e) there is an issue when running > the ptpd2 program, that leads to a kernel oops. The reason is here that > in e1000_xmit_frame() a work queue will be scheduled that has not been > initial

[PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Koehrer Mathias (ETAS/ESW5)
With the Intel 82527EI (driver: e1000e) there is an issue when running the ptpd2 program, that leads to a kernel oops. The reason is here that in e1000_xmit_frame() a work queue will be scheduled that has not been initialized in this case. The work queue "tx_hwstamp_work" will only be initialized

Re: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Alexander Duyck
On 08/06/2014 12:03 PM, Nick Krause wrote: > On Wed, Aug 6, 2014 at 11:26 AM, Alexander Duyck > wrote: >> On 08/06/2014 08:21 AM, Alexander Duyck wrote: >>> On 08/06/2014 08:09 AM, Henrique de Moraes Holschuh wrote: On Wed, Aug 6, 2014, at 11:30, Sergei Shtylyov wrote: > On 8/6/2014 6:27

Re: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Richard Cochran
On Wed, Aug 06, 2014 at 03:38:18PM -0400, Nick Krause wrote: > I checked them and this patch seems fine to me. No, it isn't fine. It ignores Alexander's comments. Mathias, can you please fix it? Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bod

Re: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Richard Cochran
On Wed, Aug 06, 2014 at 03:20:43PM -0400, Nick Krause wrote: > My question was as follows after reading the thread here is this patch > good or do I need to edit it > some more based on the thread and only putting part of the if > statement in an unlikely statement. Huh? Are you Mathias Koehrer?

Re: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Richard Cochran
On Wed, Aug 06, 2014 at 02:32:16PM +, Koehrer Mathias (ETAS/ESW5) wrote: > With the Intel 82527EI (driver: e1000e) there is an issue when running > the ptpd2 program, that leads to a kernel oops. > The reason is here that in e1000_xmit_frame() a work queue will be > scheduled that has not bee

Re: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Alexander Duyck
On 08/06/2014 08:21 AM, Alexander Duyck wrote: > On 08/06/2014 08:09 AM, Henrique de Moraes Holschuh wrote: >> On Wed, Aug 6, 2014, at 11:30, Sergei Shtylyov wrote: >>> On 8/6/2014 6:27 PM, Koehrer Mathias (ETAS/ESW5) wrote: >>> With the Intel 82527EI (driver: e1000e) there is an issue when ru

Re: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Alexander Duyck
On 08/06/2014 08:09 AM, Henrique de Moraes Holschuh wrote: > On Wed, Aug 6, 2014, at 11:30, Sergei Shtylyov wrote: >> On 8/6/2014 6:27 PM, Koehrer Mathias (ETAS/ESW5) wrote: >> >>> With the Intel 82527EI (driver: e1000e) there is an issue when running >>> the ptpd2 program, that leads to a kernel o

Re: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Henrique de Moraes Holschuh
On Wed, Aug 6, 2014, at 11:30, Sergei Shtylyov wrote: > On 8/6/2014 6:27 PM, Koehrer Mathias (ETAS/ESW5) wrote: > > > With the Intel 82527EI (driver: e1000e) there is an issue when running > > the ptpd2 program, that leads to a kernel oops. > > The reason is here that in e1000_xmit_frame() a work

[PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Koehrer Mathias (ETAS/ESW5)
With the Intel 82527EI (driver: e1000e) there is an issue when running the ptpd2 program, that leads to a kernel oops. The reason is here that in e1000_xmit_frame() a work queue will be scheduled that has not been initialized in this case. The work queue "tx_hwstamp_work" will only be initialized

Re: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Sergei Shtylyov
On 8/6/2014 6:27 PM, Koehrer Mathias (ETAS/ESW5) wrote: With the Intel 82527EI (driver: e1000e) there is an issue when running the ptpd2 program, that leads to a kernel oops. The reason is here that in e1000_xmit_frame() a work queue will be scheduled that has not been initialized in this case.

[PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Koehrer Mathias (ETAS/ESW5)
With the Intel 82527EI (driver: e1000e) there is an issue when running the ptpd2 program, that leads to a kernel oops. The reason is here that in e1000_xmit_frame() a work queue will be scheduled that has not been initialized in this case. The work queue "tx_hwstamp_work" will only be initialized

Re: [PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Sergei Shtylyov
Hello. On 8/6/2014 5:56 PM, Koehrer Mathias (ETAS/ESW5) wrote: With the Intel 82527EI (driver: e1000e) there is an issue when running the ptpd2 program, that leads to a kernel oops. The reason is here that in e1000_xmit_frame() a work queue will be scheduled that has not been initialized in t

[PATCH] Fix e1000e with Intel 82572EI that has no hardware timestamp support

2014-08-06 Thread Koehrer Mathias (ETAS/ESW5)
With the Intel 82527EI (driver: e1000e) there is an issue when running the ptpd2 program, that leads to a kernel oops. The reason is here that in e1000_xmit_frame() a work queue will be scheduled that has not been initialized in this case. The work queue "tx_hwstamp_work" will only be initialized