Re: [PATCH] Fix building lguest as module.

2008-02-21 Thread Tony Breeds
On Wed, Feb 20, 2008 at 11:01:40AM +0100, Ingo Molnar wrote: > > * Tony Breeds <[EMAIL PROTECTED]> wrote: > > > I've attached the .config FWIW > > indeed you are right... > > I fixed this build failure too - could you check whether x86.git#test > (which has all these lguest build fixes) works

Re: [PATCH] Fix building lguest as module.

2008-02-20 Thread Ingo Molnar
* Tony Breeds <[EMAIL PROTECTED]> wrote: > I've attached the .config FWIW indeed you are right... I fixed this build failure too - could you check whether x86.git#test (which has all these lguest build fixes) works fine for you: http://people.redhat.com/mingo/x86.git/README ? Thanks,

Re: [PATCH] Fix building lguest as module.

2008-02-20 Thread Ingo Molnar
* Tony Breeds <[EMAIL PROTECTED]> wrote: > > the right one is below. There's no 'LGUEST_MODULE' anymore - > > 'LGUEST_GUEST' is what should be used. > > Hmm okay I'm confused now. LGUEST_GUEST is only set when you have > guest support enabled, but if you're only building the host module[1] >

Re: [PATCH] Fix building lguest as module.

2008-02-19 Thread Tony Breeds
On Tue, Feb 19, 2008 at 02:54:01PM +0100, Ingo Molnar wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > +#endif > > > + > > > +#if defined(CONFIG_LGUEST) || defined(CONFIG_LGUEST_MODULE) > > > + BLANK(); > > > > hm. Rusty's original fix is now upstream. I've done a delta to your > > p

Re: [PATCH] Fix building lguest as module.

2008-02-19 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > +#endif > > + > > +#if defined(CONFIG_LGUEST) || defined(CONFIG_LGUEST_MODULE) > > + BLANK(); > > hm. Rusty's original fix is now upstream. I've done a delta to your > patch, find the fix is below. the right one is below. There's no 'LGUEST_MODULE

Re: [PATCH] Fix building lguest as module.

2008-02-18 Thread Ingo Molnar
* Tony Breeds <[EMAIL PROTECTED]> wrote: > +#endif > + > +#if defined(CONFIG_LGUEST) || defined(CONFIG_LGUEST_MODULE) > + BLANK(); hm. Rusty's original fix is now upstream. I've done a delta to your patch, find the fix is below. Ingo -> Subject: lguest: fix build b

[PATCH] Fix building lguest as module.

2008-02-18 Thread Tony Breeds
On Mon, Feb 04, 2008 at 07:11:10AM +1100, Rusty Russell wrote: > Lguest guest support and host support are separate config options: they used > to be tied together. Sort out which parts of asm-offsets are needed for Guest > and Host. With rusty's patch applied the errors still persist in some