Re: [PATCH] Fix an infinite retry-loop

2015-01-07 Thread Andy Shevchenko
On Sun, Jan 4, 2015 at 8:04 PM, Giel van Schijndel wrote: > This was clearly intended as a retry-10-times loop, but due to the > absence of code incrementing the loop-counter it was practically a > retry-forever loop. > > Rewritten it as a for-loop as well to make the loop-counter increment > (as

Re: [PATCH] Fix an infinite retry-loop

2015-01-04 Thread David Miller
From: Giel van Schijndel Date: Sun, 4 Jan 2015 19:04:55 +0100 > This was clearly intended as a retry-10-times loop, but due to the > absence of code incrementing the loop-counter it was practically a > retry-forever loop. > > Rewritten it as a for-loop as well to make the loop-counter increment

Re: [PATCH] Fix an infinite retry-loop

2015-01-04 Thread Giel van Schijndel
On Sun, Jan 04, 2015 at 19:04:55 +0100, Giel van Schijndel wrote: > This was clearly intended as a retry-10-times loop, but due to the > absence of code incrementing the loop-counter it was practically a > retry-forever loop. > > Rewritten it as a for-loop as well to make the loop-counter incremen

[PATCH] Fix an infinite retry-loop

2015-01-04 Thread Giel van Schijndel
This was clearly intended as a retry-10-times loop, but due to the absence of code incrementing the loop-counter it was practically a retry-forever loop. Rewritten it as a for-loop as well to make the loop-counter increment (as well as its potential absence) easier to spot. --- drivers/net/ethern