Re: [PATCH] Fix __ucmpdi2 in v4l2_norm_to_name()

2007-01-15 Thread Stelian Pop
Le dimanche 07 janvier 2007 à 09:44 -0200, Mauro Carvalho Chehab a écrit : > > > We can, however use this approach as a workaround, with > > > the proper documentation. I'll handle it after I return from vacations > > > next week. > Ok, I've wrote such patch. I should send today or tomorrow to Lin

Re: [PATCH] Fix __ucmpdi2 in v4l2_norm_to_name()

2007-01-07 Thread Mauro Carvalho Chehab
Em Qui, 2007-01-04 às 15:18 -0800, Andrew Morton escreveu: > On Thu, 04 Jan 2007 20:59:08 -0200 > Mauro Carvalho Chehab <[EMAIL PROTECTED]> wrote: > > > > The largest value we use here is 0x0200. Perhaps v4l2_std_id > > > shouldn't > > > be 64-bit? > > Too late to change it to 32 bits. It is

Re: [PATCH] Fix __ucmpdi2 in v4l2_norm_to_name()

2007-01-05 Thread Segher Boessenkool
The largest value we use here is 0x0200. Perhaps v4l2_std_id shouldn't be 64-bit? Too late to change it to 32 bits. It is at V4L2 userspace API since kernel 2.6.0. We can, however use this approach as a workaround, with the proper documentation. Maybe with a BUG_ON(id > UINT_MAX) ? If t

Re: [PATCH] Fix __ucmpdi2 in v4l2_norm_to_name()

2007-01-04 Thread Stelian Pop
Le jeudi 04 janvier 2007 à 20:59 -0200, Mauro Carvalho Chehab a écrit : > > The largest value we use here is 0x0200. Perhaps v4l2_std_id shouldn't > > be 64-bit? > Too late to change it to 32 bits. It is at V4L2 userspace API since > kernel 2.6.0. We can, however use this approach as a workar

Re: [PATCH] Fix __ucmpdi2 in v4l2_norm_to_name()

2007-01-04 Thread Andrew Morton
On Thu, 04 Jan 2007 20:59:08 -0200 Mauro Carvalho Chehab <[EMAIL PROTECTED]> wrote: > > The largest value we use here is 0x0200. Perhaps v4l2_std_id shouldn't > > be 64-bit? > Too late to change it to 32 bits. It is at V4L2 userspace API since > kernel 2.6.0. You could perhaps make it 32-bit

Re: [PATCH] Fix __ucmpdi2 in v4l2_norm_to_name()

2007-01-04 Thread Mauro Carvalho Chehab
Em Qui, 2007-01-04 às 14:48 -0800, Andrew Morton escreveu: > On Thu, 04 Jan 2007 12:10:14 +0100 > Stelian Pop <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > This patch replaces a switch statement using 64 bit values with the > > if/else equivalent in order to prevent a call __ucmpdi2 generated by >

Re: [PATCH] Fix __ucmpdi2 in v4l2_norm_to_name()

2007-01-04 Thread Andrew Morton
On Thu, 04 Jan 2007 12:10:14 +0100 Stelian Pop <[EMAIL PROTECTED]> wrote: > Hi, > > This patch replaces a switch statement using 64 bit values with the > if/else equivalent in order to prevent a call __ucmpdi2 generated by > some versions of gcc (verified with gcc-4.1.2 20060928): > > driv

Re: [v4l-dvb-maintainer] [PATCH] Fix __ucmpdi2 in v4l2_norm_to_name()

2007-01-04 Thread Stelian Pop
Le jeudi 04 janvier 2007 à 04:09 -0800, Trent Piepho a écrit : > On Thu, 4 Jan 2007, Stelian Pop wrote: > > This patch replaces a switch statement using 64 bit values with the > > if/else equivalent in order to prevent a call __ucmpdi2 generated by > > some versions of gcc (verified with gcc-4.1.2

Re: [v4l-dvb-maintainer] [PATCH] Fix __ucmpdi2 in v4l2_norm_to_name()

2007-01-04 Thread Trent Piepho
On Thu, 4 Jan 2007, Stelian Pop wrote: > This patch replaces a switch statement using 64 bit values with the > if/else equivalent in order to prevent a call __ucmpdi2 generated by > some versions of gcc (verified with gcc-4.1.2 20060928): > > drivers/built-in.o: In function `v4l2_norm_to_name

[PATCH] Fix __ucmpdi2 in v4l2_norm_to_name()

2007-01-04 Thread Stelian Pop
Hi, This patch replaces a switch statement using 64 bit values with the if/else equivalent in order to prevent a call __ucmpdi2 generated by some versions of gcc (verified with gcc-4.1.2 20060928): drivers/built-in.o: In function `v4l2_norm_to_name': (.text+0x71100): undefined ref