Re: [PATCH] Fix OOPS in show_uevent()

2007-08-10 Thread Cornelia Huck
On Fri, 10 Aug 2007 17:21:51 +0400, Pavel Emelyanov <[EMAIL PROTECTED]> wrote: > Cornelia Huck wrote: > > On Fri, 10 Aug 2007 14:23:56 +0200, > > "Kay Sievers" <[EMAIL PROTECTED]> wrote: > > > >> But we still don't update the remaining buffer size and the remaining > >> array fields which are lef

Re: [PATCH] Fix OOPS in show_uevent()

2007-08-10 Thread Pavel Emelyanov
Cornelia Huck wrote: On Fri, 10 Aug 2007 14:23:56 +0200, "Kay Sievers" <[EMAIL PROTECTED]> wrote: But we still don't update the remaining buffer size and the remaining array fields which are left after the call. Shouldn't we instead just change the: int (*dev_uevent)(struct device *dev,

Re: [PATCH] Fix OOPS in show_uevent()

2007-08-10 Thread Cornelia Huck
On Fri, 10 Aug 2007 14:23:56 +0200, "Kay Sievers" <[EMAIL PROTECTED]> wrote: > But we still don't update the remaining buffer size and the remaining > array fields which are left after the call. Shouldn't we instead just > change the: >int (*dev_uevent)(struct device *dev, >

Re: [PATCH] Fix OOPS in show_uevent()

2007-08-10 Thread Kay Sievers
On 8/10/07, Pavel Emelyanov <[EMAIL PROTECTED]> wrote: > The platform_uevent() callback called via > show_uevent() > dev_uevent() > platform_uevent() > forgot to set NULL to the last envp pointer and this caused the > show_uevent() oops while printing all the envp pointers like this: > The l

Re: [PATCH] Fix OOPS in show_uevent()

2007-08-10 Thread Cornelia Huck
On Fri, 10 Aug 2007 14:13:43 +0400, Pavel Emelyanov <[EMAIL PROTECTED]> wrote: > The last hunk in this patch fixes this. Looks sane. > The other problem is that the envp passed to bus, type and platform callbacks > from dev_uevent() is the same, so the callbacks can overwrite the info, > writte

[PATCH] Fix OOPS in show_uevent()

2007-08-10 Thread Pavel Emelyanov
The platform_uevent() callback called via show_uevent() dev_uevent() platform_uevent() forgot to set NULL to the last envp pointer and this caused the show_uevent() oops while printing all the envp pointers like this: BUG: unable to handle kernel paging request at virtual address 000280d0 ...