Re: [PATCH] Fix NULL ptr dereference in pci_bus_assign_domain_nr() on ARM

2016-03-08 Thread Lorenzo Pieralisi
On Mon, Mar 07, 2016 at 10:24:27PM -0600, Bjorn Helgaas wrote: [...] > > > Actually, I did find one problem report: > > > http://forum.doozan.com/read.php?2,17868,22070,quote=1 from last May, > > > but apparently it got lost in a forum and never found its way > > > upstream. > > > > > > I rework

Re: [PATCH] Fix NULL ptr dereference in pci_bus_assign_domain_nr() on ARM

2016-03-07 Thread Bjorn Helgaas
On Tue, Mar 08, 2016 at 03:01:20AM +, Lorenzo Pieralisi wrote: > On Mon, Mar 07, 2016 at 04:33:11PM -0600, Bjorn Helgaas wrote: > > [+cc Lorenzo] > > > > On Tue, Mar 01, 2016 at 07:07:18AM +0100, Krzysztof Ha??asa wrote: > > > Many ARM platforms use a wrapper: > > > /* > > > * Compatibility w

Re: [PATCH] Fix NULL ptr dereference in pci_bus_assign_domain_nr() on ARM

2016-03-07 Thread Lorenzo Pieralisi
On Mon, Mar 07, 2016 at 04:33:11PM -0600, Bjorn Helgaas wrote: > [+cc Lorenzo] > > On Tue, Mar 01, 2016 at 07:07:18AM +0100, Krzysztof Ha??asa wrote: > > Many ARM platforms use a wrapper: > > /* > > * Compatibility wrapper for older platforms that do not care about > > * passing the parent devic

Re: [PATCH] Fix NULL ptr dereference in pci_bus_assign_domain_nr() on ARM

2016-03-07 Thread Bjorn Helgaas
[+cc Lorenzo] On Tue, Mar 01, 2016 at 07:07:18AM +0100, Krzysztof Hałasa wrote: > Many ARM platforms use a wrapper: > /* > * Compatibility wrapper for older platforms that do not care about > * passing the parent device. > */ > static inline void pci_common_init(struct hw_pci *hw) > { >

Re: [PATCH] Fix NULL ptr dereference in pci_bus_assign_domain_nr() on ARM

2016-03-07 Thread Krzysztof Hałasa
Bjorn Helgaas writes: >> At least CNS3xxx doesn't boot. I haven't verified a couple of others, >> but they may be broken as well. > > Good, thanks. Also (I should have asked this before), please include a > "Fixes:" line so we know exactly when this broke and what stable kernels > need the fix.

Re: [PATCH] Fix NULL ptr dereference in pci_bus_assign_domain_nr() on ARM

2016-03-04 Thread Bjorn Helgaas
On Fri, Mar 04, 2016 at 07:13:49AM +0100, Krzysztof Hałasa wrote: > Hi Bjorn, > > Bjorn Helgaas writes: > > > On Tue, Mar 01, 2016 at 07:07:18AM +0100, Krzysztof Hałasa wrote: > >> Many ARM platforms use a wrapper: > >> /* > >> * Compatibility wrapper for older platforms that do not care about

Re: [PATCH] Fix NULL ptr dereference in pci_bus_assign_domain_nr() on ARM

2016-03-03 Thread Krzysztof Hałasa
Hi Bjorn, Bjorn Helgaas writes: > On Tue, Mar 01, 2016 at 07:07:18AM +0100, Krzysztof Hałasa wrote: >> Many ARM platforms use a wrapper: >> /* >> * Compatibility wrapper for older platforms that do not care about >> * passing the parent device. >> */ >> static inline void pci_common_init(stru

Re: [PATCH] Fix NULL ptr dereference in pci_bus_assign_domain_nr() on ARM

2016-03-03 Thread Bjorn Helgaas
Hi Krzysztof, On Tue, Mar 01, 2016 at 07:07:18AM +0100, Krzysztof Hałasa wrote: > Many ARM platforms use a wrapper: > /* > * Compatibility wrapper for older platforms that do not care about > * passing the parent device. > */ > static inline void pci_common_init(struct hw_pci *hw) > { >

[PATCH] Fix NULL ptr dereference in pci_bus_assign_domain_nr() on ARM

2016-02-29 Thread Krzysztof Hałasa
Many ARM platforms use a wrapper: /* * Compatibility wrapper for older platforms that do not care about * passing the parent device. */ static inline void pci_common_init(struct hw_pci *hw) { pci_common_init_dev(NULL, hw); } which means that pci_bus_assign_domain_nr() can be called with