Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-31 Thread Oliver Neukum
Am Mittwoch, 31. Januar 2007 11:55 schrieb Jiri Kosina: > On Tue, 30 Jan 2007, Oliver Neukum wrote: > > > > Is there any hardware independent alternative to turn off USB devices? > > Would you test a patch for autosuspension of hid devices? > > Hi Oliver, > > do you have such patch already? I wo

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-31 Thread Jiri Kosina
On Tue, 30 Jan 2007, Oliver Neukum wrote: > > Is there any hardware independent alternative to turn off USB devices? > Would you test a patch for autosuspension of hid devices? Hi Oliver, do you have such patch already? I would also like to see it; if it looks OK, I will push it to -mm through

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-31 Thread Pavel Machek
Hi! > > Change breaking that was 'introduce suspend early to fix suspend on > > mac mini', by Linus, IIRC. So no, it is not easy to revert this one. > > But it's easy to fix it. Either drivers need suspend routines that Yes, that's right. It is easy to fix, but not as easy as "just revert". > c

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-30 Thread Eric Piel
01/30/2007 07:47 PM, Oliver Neukum wrote/a écrit: Am Dienstag, 30. Januar 2007 19:43 schrieb Eric Piel: I have been using this interface for a _long_ time (before june 2005, cf http://marc.theaimsgroup.com/?l=linux-usb-devel&m=111869558800526&w=2) and for different things than power saving: I

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-30 Thread Oliver Neukum
Am Dienstag, 30. Januar 2007 19:43 schrieb Eric Piel: > I have been using this interface for a _long_ time (before june 2005, cf > http://marc.theaimsgroup.com/?l=linux-usb-devel&m=111869558800526&w=2) > and for different things than power saving: I can turn off my (usb) > optical mouse when wa

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-30 Thread Eric Piel
01/27/2007 02:17 PM, Pavel Machek wrote/a écrit: Hi! In 2.6.19, support for splitting driver suspend and resume callbacks into interrupt and non-interrupt contexts was added. Unfortunately, this broke /sys/device/.../power/state support for all devices. In the long run, this should be obsolet

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-29 Thread Stephen Hemminger
On Fri, 26 Jan 2007 19:02:37 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > On Friday 26 January 2007 5:19 pm, Matthew Garrett wrote: > > On Fri, Jan 26, 2007 at 04:42:56PM -0800, David Brownell wrote: > > > On Friday 26 January 2007 3:15 pm, Matthew Garrett wrote: > > > > It's certainly the ca

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-27 Thread Matthew Garrett
On Sat, Jan 27, 2007 at 05:38:04PM +, Pavel Machek wrote: > Change breaking that was 'introduce suspend early to fix suspend on > mac mini', by Linus, IIRC. So no, it is not easy to revert this one. But it's easy to fix it. Either drivers need suspend routines that are called without interru

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-27 Thread Pavel Machek
Hi! > > > > I thought the resolution was that fixing a few of those drivers > > > > should solve the problem Matthew needed resolved, and that in > > > > the meanwhile "rmmod drivername" should suffice. There also seemed > > > > to be agreement that power management for wireless devices needed >

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-27 Thread Pavel Machek
Hi! > > This patch allows the bus driver to check whether a specific driver > > requires the split. If not, the 2.6.18 functionality is restored. It > > also alters feature-removals.txt to note that the deprecated > > functionality should not be removed until a replacement actually exists. > >

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-27 Thread Pavel Machek
Hi! > In 2.6.19, support for splitting driver suspend and resume callbacks > into interrupt and non-interrupt contexts was added. Unfortunately, this > broke /sys/device/.../power/state support for all devices. In the long > run, this should be obsoleted by power management support in the > in

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-26 Thread David Brownell
On Friday 26 January 2007 5:19 pm, Matthew Garrett wrote: > On Fri, Jan 26, 2007 at 04:42:56PM -0800, David Brownell wrote: > > On Friday 26 January 2007 3:15 pm, Matthew Garrett wrote: > > > It's certainly the case that fixing those drivers would result in a > > > better long-term situation - how

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-26 Thread David Brownell
> > > It's certainly the case that fixing those drivers would result in a > > > better long-term situation - however, nobody currently seems to have any > > > interest in doing so... > > > > And the way these things work, unfortunately, is that merging your patch > > would ensure nobody ever get

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-26 Thread Matthew Garrett
On Fri, Jan 26, 2007 at 12:42:26PM -0800, Greg KH wrote: > No, it's not stable material, as drivers would have to be modified to > support it, and that is adding new stuff. See my other comment about > why this was changed because it was broken... Which drivers? The current code simply bails if

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-26 Thread Matthew Garrett
On Fri, Jan 26, 2007 at 04:42:56PM -0800, David Brownell wrote: > On Friday 26 January 2007 3:15 pm, Matthew Garrett wrote: > > It's certainly the case that fixing those drivers would result in a > > better long-term situation - however, nobody currently seems to have any > > interest in doing so

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-26 Thread Andrew Morton
On Fri, 26 Jan 2007 16:42:56 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > On Friday 26 January 2007 3:15 pm, Matthew Garrett wrote: > > On Fri, Jan 26, 2007 at 01:56:41PM -0800, David Brownell wrote: > > > > > I thought the resolution was that fixing a few of those drivers > > > should solve

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-26 Thread David Brownell
On Friday 26 January 2007 3:15 pm, Matthew Garrett wrote: > On Fri, Jan 26, 2007 at 01:56:41PM -0800, David Brownell wrote: > > > I thought the resolution was that fixing a few of those drivers > > should solve the problem Matthew needed resolved, and that in > > the meanwhile "rmmod drivername" s

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-26 Thread Matthew Garrett
On Fri, Jan 26, 2007 at 01:56:41PM -0800, David Brownell wrote: > I thought the resolution was that fixing a few of those drivers > should solve the problem Matthew needed resolved, and that in > the meanwhile "rmmod drivername" should suffice. There also seemed > to be agreement that power manag

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-26 Thread Greg KH
On Fri, Jan 26, 2007 at 01:56:41PM -0800, David Brownell wrote: > > Or am I misstating that long thread? David, your thoughts? > > My recollection of that thread was that *NOBODY* claimed that a > replacement of that (broken-by-design) mechanism would ever exist. > > However, there was some inte

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-26 Thread David Brownell
On Friday 26 January 2007 12:41 pm, Greg KH wrote: > On Thu, Jan 25, 2007 at 05:00:09AM +, Matthew Garrett wrote: > > This patch allows the bus driver to check whether a specific driver > > requires the split. If not, the 2.6.18 functionality is restored. It > > also alters feature-removals.

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-26 Thread Greg KH
On Fri, Jan 26, 2007 at 11:59:05AM -0800, Andrew Morton wrote: > On Thu, 25 Jan 2007 05:00:09 + > Matthew Garrett <[EMAIL PROTECTED]> wrote: > > > In 2.6.19, support for splitting driver suspend and resume callbacks > > into interrupt and non-interrupt contexts was added. Unfortunately, this

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-26 Thread Greg KH
On Thu, Jan 25, 2007 at 05:00:09AM +, Matthew Garrett wrote: > In 2.6.19, support for splitting driver suspend and resume callbacks > into interrupt and non-interrupt contexts was added. Unfortunately, this > broke /sys/device/.../power/state support for all devices. In the long > run, this

Re: [PATCH] Fix /sys/device/.../power/state regression

2007-01-26 Thread Andrew Morton
On Thu, 25 Jan 2007 05:00:09 + Matthew Garrett <[EMAIL PROTECTED]> wrote: > In 2.6.19, support for splitting driver suspend and resume callbacks > into interrupt and non-interrupt contexts was added. Unfortunately, this > broke /sys/device/.../power/state support for all devices. In the long

[PATCH] Fix /sys/device/.../power/state regression

2007-01-24 Thread Matthew Garrett
In 2.6.19, support for splitting driver suspend and resume callbacks into interrupt and non-interrupt contexts was added. Unfortunately, this broke /sys/device/.../power/state support for all devices. In the long run, this should be obsoleted by power management support in the individual driver