Re: [PATCH] FRV: Fix the extern declaration of kallsyms_num_syms [try #2]

2007-11-15 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > hm, OK, so it lines up with what scripts/kallsyms.c presently does. I'm sure there's a way to pass the kallsyms_num_syms value directly by way of the linker rather than consigning it to a bit of memory. The immediately obvious way is to declare it to be

Re: [PATCH] FRV: Fix the extern declaration of kallsyms_num_syms [try #2]

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 14:40:07 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > But it all strikes me as a bit fragile and grotty. Perhaps longer-term it > would be better if scripts/kallsyms.c were to also emit a header file which > declares all the things which that program emits the definitions

Re: [PATCH] FRV: Fix the extern declaration of kallsyms_num_syms [try #2]

2007-11-15 Thread Andrew Morton
On Tue, 13 Nov 2007 16:53:16 + David Howells <[EMAIL PROTECTED]> wrote: > From: David Howells <[EMAIL PROTECTED]> > > Fix the extern declaration of kallsyms_num_syms to indicate that the symbol > does not reside in the small-data storage space, and so may not be accessed > relative to the sma

Re: [PATCH] FRV: Fix the extern declaration of kallsyms_num_syms

2007-11-13 Thread David Howells
David Howells <[EMAIL PROTECTED]> wrote: > > > +extern const unsigned long kallsyms_num_syms > > > +__nongpreldata __attribute__((weak)); Rather than using __nongpreldata, I should be able to say that it's in .rodata - which seems to be more correct anyway - and throw into a comment to say why.

[PATCH] FRV: Fix the extern declaration of kallsyms_num_syms [try #2]

2007-11-13 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> Fix the extern declaration of kallsyms_num_syms to indicate that the symbol does not reside in the small-data storage space, and so may not be accessed relative to the small data base register. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- kernel/k

Re: [PATCH] FRV: Fix the extern declaration of kallsyms_num_syms

2007-11-13 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > > +extern const unsigned long kallsyms_num_syms > > +__nongpreldata __attribute__((weak)); > > umm, this makes Linux an frv-only operating system... Oops. Well... is there any other CPU? Apart from MN10300, that is... :-) I remember I had to fix a bu

Re: [PATCH] FRV: Fix the extern declaration of kallsyms_num_syms

2007-11-09 Thread Andrew Morton
On Tue, 06 Nov 2007 21:48:20 + David Howells <[EMAIL PROTECTED]> wrote: > From: David Howells <[EMAIL PROTECTED]> > > Fix the extern declaration of kallsyms_num_syms to indicate that the symbol > does not reside in the small-data storage space, and so may not be accessed > relative to the sma

[PATCH] FRV: Fix the extern declaration of kallsyms_num_syms

2007-11-06 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> Fix the extern declaration of kallsyms_num_syms to indicate that the symbol does not reside in the small-data storage space, and so may not be accessed relative to the small data base register. Signed-off-by: David Howells <[EMAIL PROTECTED]> --- kernel/k