Re: [PATCH] EFI x86: pass firmware call parameters on the stack

2007-02-01 Thread bibo,mao
Frederic Riss wrote: 2007/2/1, bibo,mao <[EMAIL PROTECTED]>: currently x86_64 kernel does not support efi, efi convention comply to MS convention. On ia32 parameter is passed on stack, on x86_64 parameter is passed by registers but that is different from x86_64 linux convention. Is an x86_64

Re: [PATCH] EFI x86: pass firmware call parameters on the stack

2007-02-01 Thread Frederic Riss
2007/2/1, bibo,mao <[EMAIL PROTECTED]>: currently x86_64 kernel does not support efi, efi convention comply to MS convention. On ia32 parameter is passed on stack, on x86_64 parameter is passed by registers but that is different from x86_64 linux convention. Is an x86_64 EFI firmware required t

Re: [PATCH] EFI x86: pass firmware call parameters on the stack

2007-01-31 Thread bibo,mao
Frédéric Riss wrote: Le mardi 30 janvier 2007 à 12:17 -0700, Bjorn Helgaas a écrit : On Tuesday 30 January 2007 12:01, Frédéric Riss wrote: When calling into an EFI firmware, the parameters need to be passed on the stack. The recent change to use -mregparm=3 breaks x86 EFI support. This pat

Re: [PATCH] EFI x86: pass firmware call parameters on the stack

2007-01-30 Thread Frédéric Riss
Le mardi 30 janvier 2007 à 12:17 -0700, Bjorn Helgaas a écrit : > On Tuesday 30 January 2007 12:01, Frédéric Riss wrote: > > When calling into an EFI firmware, the parameters need to be passed on > > the stack. The recent change to use -mregparm=3 breaks x86 EFI support. > > This patch is needed to

Re: [PATCH] EFI x86: pass firmware call parameters on the stack

2007-01-30 Thread Bjorn Helgaas
On Tuesday 30 January 2007 12:01, Frédéric Riss wrote: > When calling into an EFI firmware, the parameters need to be passed on > the stack. The recent change to use -mregparm=3 breaks x86 EFI support. > This patch is needed to allow the new Intel-based Macs to suspend to ram > when run in EFI mode

Re: [PATCH] EFI x86: pass firmware call parameters on the stack

2007-01-30 Thread Frédéric Riss
Le mardi 30 janvier 2007 à 11:10 -0800, Andrew Morton a écrit : > > This patch fixes the issue for x86, but the file is also used by IA64. I > > would have used asmlinkage to force arguments on the stack, but it has a > > special meaning on IA64, thus I used a raw regparm(0) GCC attribute. > > This

Re: [PATCH] EFI x86: pass firmware call parameters on the stack

2007-01-30 Thread Andrew Morton
On Tue, 30 Jan 2007 20:01:18 +0100 Frédéric Riss <[EMAIL PROTECTED]> wrote: > > When calling into an EFI firmware, the parameters need to be passed on > the stack. The recent change to use -mregparm=3 breaks x86 EFI support. > This patch is needed to allow the new Intel-based Macs to suspend to r

[PATCH] EFI x86: pass firmware call parameters on the stack

2007-01-30 Thread Frédéric Riss
When calling into an EFI firmware, the parameters need to be passed on the stack. The recent change to use -mregparm=3 breaks x86 EFI support. This patch is needed to allow the new Intel-based Macs to suspend to ram when run in EFI mode (efi.get_time is called during the suspend phase). Signed-of