Re: [PATCH] EDAC: use debugfs_remove_recursive instead of debugfs_remove

On Tue, Oct 13, 2015 at 04:45:26PM +0800, Tan Xiaojun wrote: > Sorry, I don't describe it well. I do test like that: > 1)open EDAC config and open CONFIG_EDAC_DEBUG > 2)insmod a edac_mc module (like i3000_edac or others in drivers/edac/) > 3)rmmod this module > 4)we can also see files under /sys/ke

Re: [PATCH] EDAC: use debugfs_remove_recursive instead of debugfs_remove

On 2015/10/13 15:41, Borislav Petkov wrote: > On Tue, Oct 13, 2015 at 10:22:51AM +0800, Tan Xiaojun wrote: >> debugfs_remove is used to remove a file or an empty directory from >> the debugfs filesystem, but mci->debugfs is not empty. > > How exactly do you trigger this? And by "this" I'm not even

Re: [PATCH] EDAC: use debugfs_remove_recursive instead of debugfs_remove

On Tue, Oct 13, 2015 at 10:22:51AM +0800, Tan Xiaojun wrote: > debugfs_remove is used to remove a file or an empty directory from > the debugfs filesystem, but mci->debugfs is not empty. How exactly do you trigger this? And by "this" I'm not even sure what the problem is as your commit message doe

[PATCH] EDAC: use debugfs_remove_recursive instead of debugfs_remove

debugfs_remove is used to remove a file or an empty directory from the debugfs filesystem, but mci->debugfs is not empty. This is not easily discovered, because debugfs_remove return nothing when failed. Reported-by: Yun Wu (Abel) Signed-off-by: Tan Xiaojun --- drivers/edac/edac_mc_sysfs.c | 4