Re: [PATCH] EDAC: Fix global-out-of-bounds write when setting edac_mc_poll_msec

On Thu, Jun 27, 2019 at 06:11:18PM +0100, James Morse wrote: > Hello, > > (CC: +Tony Luck. > Original Patch: lore.kernel.org/r/20190626054011.30044-1-de...@etsukata.com ) Heh: My mail agent "helpfully" made that clickable, but as a "mailto:"; URL rather than an https: one! > > On 26/06/2019 06:

Re: [PATCH] EDAC: Fix global-out-of-bounds write when setting edac_mc_poll_msec

Hello, (CC: +Tony Luck. Original Patch: lore.kernel.org/r/20190626054011.30044-1-de...@etsukata.com ) On 26/06/2019 06:40, Eiichi Tsukata wrote: > Commit 9da21b1509d8 ("EDAC: Poll timeout cannot be zero, p2") assumes > edac_mc_poll_msec to be unsigned long, but the type of the variable still > r

[PATCH] EDAC: Fix global-out-of-bounds write when setting edac_mc_poll_msec

Commit 9da21b1509d8 ("EDAC: Poll timeout cannot be zero, p2") assumes edac_mc_poll_msec to be unsigned long, but the type of the variable still remained as int. Setting edac_mc_poll_msec can trigger out-of-bounds write. Reproducer: # echo 1001 > /sys/module/edac_core/parameters/edac_mc_poll_mse