Re: [PATCH] EDAC, altera: Add missing of_node_put()

On Thu, Feb 14, 2019 at 10:15:20AM -0600, Thor Thayer wrote: > Yes, I missed the error path. I mistakingly thought of_node_put(np_eccmgr) > would catch the exit of both branches but I declared sysmgr_np instead of > re-using np_eccmgr. I'll clean that up in a separate patch (actually this > code wi

Re: [PATCH] EDAC, altera: Add missing of_node_put()

Hi, On 2/14/19 12:39 AM, Huang Zijiang wrote: The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented here after the last usage. Signed-off-by: Huang Zijiang --- drivers/edac/altera_edac.c | 5 - 1 file changed, 4 insertions(+

[PATCH] EDAC, altera: Add missing of_node_put()

The call to of_parse_phandle returns a node pointer with refcount incremented thus it must be explicitly decremented here after the last usage. Signed-off-by: Huang Zijiang --- drivers/edac/altera_edac.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/edac/altera_