Re: [PATCH] Driver core: Fix device_add_attrs() error code path

2013-12-12 Thread Rafael J. Wysocki
On Thursday, December 12, 2013 03:13:33 PM Greg Kroah-Hartman wrote: > On Thu, Dec 12, 2013 at 06:11:02AM +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > If the addition of dev_attr_online fails, device_add_attrs() should > > remove device attribute groups as well as type and

Re: [PATCH] Driver core: Fix device_add_attrs() error code path

2013-12-12 Thread Greg Kroah-Hartman
On Thu, Dec 12, 2013 at 06:11:02AM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > If the addition of dev_attr_online fails, device_add_attrs() should > remove device attribute groups as well as type and class attribute > groups before returning an error code. Make that happen. >

Re: [PATCH] Driver core: Fix device_add_attrs() error code path

2013-12-12 Thread Toshi Kani
On Thu, 2013-12-12 at 06:11 +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > If the addition of dev_attr_online fails, device_add_attrs() should > remove device attribute groups as well as type and class attribute > groups before returning an error code. Make that happen. > > Signe

[PATCH] Driver core: Fix device_add_attrs() error code path

2013-12-11 Thread Rafael J. Wysocki
From: Rafael J. Wysocki If the addition of dev_attr_online fails, device_add_attrs() should remove device attribute groups as well as type and class attribute groups before returning an error code. Make that happen. Signed-off-by: Rafael J. Wysocki --- drivers/base/core.c |4 +++- 1 file