Re: [PATCH] Don't needlessly dirty mlocked pages when initially faulting them in.

2007-10-12 Thread Mauro Giachero
On 7/27/07, Peter Zijlstra <[EMAIL PROTECTED]> wrote: > [...] > +* We want to touch writable mappings with a write fault in otder > [...] otder -> order Greetings Mauro - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: [PATCH] Don't needlessly dirty mlocked pages when initially faulting them in.

2007-10-12 Thread Suleiman Souhlal
On Jul 26, 2007, at 11:33 PM, Peter Zijlstra wrote: On Thu, 2007-07-26 at 17:23 -0700, Andrew Morton wrote: On Thu, 26 Jul 2007 16:52:44 -0700 Suleiman Souhlal <[EMAIL PROTECTED]> wrote: make_pages_present() is dirtying mlocked pages if the VMA is writable, even though it shouldn't, by te

Re: [PATCH] Don't needlessly dirty mlocked pages when initially faulting them in.

2007-07-26 Thread Peter Zijlstra
On Thu, 2007-07-26 at 17:23 -0700, Andrew Morton wrote: > On Thu, 26 Jul 2007 16:52:44 -0700 Suleiman Souhlal <[EMAIL PROTECTED]> wrote: > > > make_pages_present() is dirtying mlocked pages if the VMA is writable, even > > though it shouldn't, by telling get_user_pages() to simulate a write fault.

Re: [PATCH] Don't needlessly dirty mlocked pages when initially faulting them in.

2007-07-26 Thread Andrew Morton
On Thu, 26 Jul 2007 16:52:44 -0700 Suleiman Souhlal <[EMAIL PROTECTED]> wrote: > make_pages_present() is dirtying mlocked pages if the VMA is writable, even > though it shouldn't, by telling get_user_pages() to simulate a write fault. > > A simple way to test this is to mlock a multi-GB file, and

[PATCH] Don't needlessly dirty mlocked pages when initially faulting them in.

2007-07-26 Thread Suleiman Souhlal
make_pages_present() is dirtying mlocked pages if the VMA is writable, even though it shouldn't, by telling get_user_pages() to simulate a write fault. A simple way to test this is to mlock a multi-GB file, and then sync. The sync will take a long time. As far as I can see, it should be safe to j