Re: [PATCH] Don't map random pages if swapoff errors

2007-01-19 Thread Alexey Kuznetsov
Hello! > Getting an error there is all the more reason to proceed > with the swapoff, not to give up and break out of it. Yes, from this viewpoint more reasonable approach would be to untie corresponding ptes from swap entry and mark them as invalid to trigger fault on access. Not even tried sim

Re: [PATCH] Don't map random pages if swapoff errors

2007-01-19 Thread Hugh Dickins
On Fri, 19 Jan 2007, Alexey Dobriyan wrote: > From: Alexey Kuznetsov <[EMAIL PROTECTED]> > > If read failed we cannot map not-uptodate page to user space. Good point. > Actually, we are in serious troubles, we do not even know what > process to kill. True, though we don't really want to kill a

[PATCH] Don't map random pages if swapoff errors

2007-01-19 Thread Alexey Dobriyan
From: Alexey Kuznetsov <[EMAIL PROTECTED]> If read failed we cannot map not-uptodate page to user space. Actually, we are in serious troubles, we do not even know what process to kill. So, the only variant remains: to stop swapoff() and allow someone to kill processes to zap invalid pages. Signed