Re: [PATCH] Don't clobber access methods when !regmap

2012-09-06 Thread Pantelis Antoniou
Hi, On Sep 6, 2012, at 5:01 PM, Peter Ujfalusi wrote: > Hi, > > On 09/05/2012 07:43 PM, Pantelis Antoniou wrote: >> The driver in question (twl4030.c) does not call >> snd_soc_codec_set_cache_io(). >> However the snd-soc core does call it in sound/soc/soc-core.c in >> soc_probe_codec. >> >> I

Re: [PATCH] Don't clobber access methods when !regmap

2012-09-06 Thread Peter Ujfalusi
Hi, On 09/05/2012 07:43 PM, Pantelis Antoniou wrote: > The driver in question (twl4030.c) does not call snd_soc_codec_set_cache_io(). > However the snd-soc core does call it in sound/soc/soc-core.c in > soc_probe_codec. > > I do see that there's a commit 98d3088e534a2a61f6690b5426909b0c3b57a785

Re: [PATCH] Don't clobber access methods when !regmap

2012-09-05 Thread Pantelis Antoniou
Hi Lars, On Sep 5, 2012, at 7:36 PM, Lars-Peter Clausen wrote: > On 09/06/2012 03:45 PM, Pantelis Antoniou wrote: >> A snd-soc driver that doesn't support regmap blow up horribly >> when you assume that regmap is available. Fix it by marking >> the driver as not supporting regmap & not clobbering

Re: [PATCH] Don't clobber access methods when !regmap

2012-09-05 Thread Lars-Peter Clausen
On 09/06/2012 03:45 PM, Pantelis Antoniou wrote: > A snd-soc driver that doesn't support regmap blow up horribly > when you assume that regmap is available. Fix it by marking > the driver as not supporting regmap & not clobbering the codec > access methods. > > This is immediately noticeable on th

[PATCH] Don't clobber access methods when !regmap

2012-09-05 Thread Pantelis Antoniou
A snd-soc driver that doesn't support regmap blow up horribly when you assume that regmap is available. Fix it by marking the driver as not supporting regmap & not clobbering the codec access methods. This is immediately noticeable on the beagleboard where we crash, since we might have REGMAP enab