On Wed, Jan 16, 2008 at 11:21:21PM +0100, Andi Kleen wrote:
> Deprecate checkpatch.pl --file mode; add warning; add --file-force
>
> As discussed on linux-kernel checkpatch.pl only patches for whole
> files have a significant cost. Better such changes should be only
> done together with other cha
On Wed, Jan 16, 2008 at 11:21:21PM +0100, Andi Kleen wrote:
>
> I'm not entirely sure who collects checkpatch patches for .25 -- i thought it
> was Andy W., but he doesn't seem to answer. Anyways whoever does it please
> queue this patch for the next checkpatch.pl update. Or perhaps it could
> be
I'm not entirely sure who collects checkpatch patches for .25 -- i thought it
was Andy W., but he doesn't seem to answer. Anyways whoever does it please
queue this patch for the next checkpatch.pl update. Or perhaps it could
be put into -mm?
Thanks,
-Andi
Deprecate checkpatch.pl --file mode
On Tue, 2008-01-08 at 16:14 -0500, Theodore Tso wrote:
> On Tue, Jan 08, 2008 at 12:19:44PM -0800, Daniel Walker wrote:
> > > But is discourage the creation of pure clean-up patches because it
> > > may have a disturbing effect on several other peoples work.
> >
> > pure clean ups are _good_ patc
On Tue, Jan 08, 2008 at 12:19:44PM -0800, Daniel Walker wrote:
> > But is discourage the creation of pure clean-up patches because it
> > may have a disturbing effect on several other peoples work.
>
> pure clean ups are _good_ patches , are they not?
>
Not necessarily. Whether or not it is req
On Tue, 2008-01-08 at 20:21 +0100, Sam Ravnborg wrote:
> But is discourage the creation of pure clean-up patches because it
> may have a disturbing effect on several other peoples work.
pure clean ups are _good_ patches , are they not?
Daniel
--
To unsubscribe from this list: send the line "un
On Tuesday 08 January 2008, Sam Ravnborg wrote:
> On Tue, Jan 08, 2008 at 08:50:33AM -0800, Daniel Walker wrote:
> >
> > On Tue, 2008-01-08 at 17:14 +0100, Andi Kleen wrote:
> >
> >
> > > +if ($file) {
> > > + print < > > +WARNING: Using --file mode. Please do not send patches to linux-kernel
>
> But is discourage the creation of pure clean-up patches because it
> may have a disturbing effect on several other peoples work.
Exactly. Or rather it spells out when exactly pure cleanup patches are ok.
-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the bod
>
> What I was saying in my first email was we can throttle "patches"
> arbitrarily (I think Andrew/Linus even have a merge period for these
> types of patches) .. So that's not the issue .. I feel style clean ups
> are fundamentally good.. So what we don't want to do is discourage the
> creation
On Tue, 2008-01-08 at 13:20 -0500, Theodore Tso wrote:
> On Tue, Jan 08, 2008 at 10:01:19AM -0800, Daniel Walker wrote:
> > > It is a simple pain/benefit issue.
> > > Fixing the 25 errors and 13 warnings in kernel/profile.c may look
> > > like an easy task but then we put additional burden on the
On Tue, Jan 08, 2008 at 10:01:19AM -0800, Daniel Walker wrote:
> > It is a simple pain/benefit issue.
> > Fixing the 25 errors and 13 warnings in kernel/profile.c may look
> > like an easy task but then we put additional burden on the 10 people
> > that have patches pending for this file.
>
> This
On Tue, 2008-01-08 at 18:53 +0100, Sam Ravnborg wrote:
> On Tue, Jan 08, 2008 at 08:50:33AM -0800, Daniel Walker wrote:
> >
> > On Tue, 2008-01-08 at 17:14 +0100, Andi Kleen wrote:
> >
> >
> > > +if ($file) {
> > > + print < > > +WARNING: Using --file mode. Please do not send patches to linux-k
On Tue, Jan 08, 2008 at 08:50:33AM -0800, Daniel Walker wrote:
>
> On Tue, 2008-01-08 at 17:14 +0100, Andi Kleen wrote:
>
>
> > +if ($file) {
> > + print < > +WARNING: Using --file mode. Please do not send patches to linux-kernel
> > +that change whole existing files if you did not significant
On Tue, 2008-01-08 at 17:14 +0100, Andi Kleen wrote:
> +if ($file) {
> + print < +WARNING: Using --file mode. Please do not send patches to linux-kernel
> +that change whole existing files if you did not significantly change most
> +of the the file for other reasons anyways or just wrote the
Deprecate checkpatch.pl --file mode; add warning; add --file-force
As discussed on linux-kernel checkpatch.pl only patches for whole
files have a significant cost for the maintenance process.
Better such changes should be only
done together with other changes. Add a explicit warning about
this;
15 matches
Mail list logo
