Re: [PATCH] Cleanup __pvclock_read_cycles to remove useless variables

2016-05-11 Thread Minfei Huang
On 05/11/16 at 04:24P, Paolo Bonzini wrote: > > > On 30/04/2016 23:57, Andy Lutomirski wrote: > >> > Should we kill __pvclock_read_cycles in favor of vread_pvclock? It looks > >> > doable at a quick scan... > >> > > > The in-kernel version might have to be a bit different because it > > needs to

Re: [PATCH] Cleanup __pvclock_read_cycles to remove useless variables

2016-05-11 Thread Paolo Bonzini
On 30/04/2016 23:57, Andy Lutomirski wrote: >> > Should we kill __pvclock_read_cycles in favor of vread_pvclock? It looks >> > doable at a quick scan... >> > > The in-kernel version might have to be a bit different because it > needs to handle the !stable case. If !stable, it should just use the

Re: [PATCH] Cleanup __pvclock_read_cycles to remove useless variables

2016-04-30 Thread Andy Lutomirski
On Apr 30, 2016 12:17 PM, "Borislav Petkov" wrote: > > On Sat, Apr 30, 2016 at 10:47:49AM -0700, Andy Lutomirski wrote: > > Take a look at vread_pvclock. I decided that __pvclock_read_cycles > > was too ugly to use and was very slow and I just gave up and rewrote > > it. > > Should we kill __pvcl

Re: [PATCH] Cleanup __pvclock_read_cycles to remove useless variables

2016-04-30 Thread Borislav Petkov
On Sat, Apr 30, 2016 at 10:47:49AM -0700, Andy Lutomirski wrote: > Take a look at vread_pvclock. I decided that __pvclock_read_cycles > was too ugly to use and was very slow and I just gave up and rewrote > it. Should we kill __pvclock_read_cycles in favor of vread_pvclock? It looks doable at a q

Re: [PATCH] Cleanup __pvclock_read_cycles to remove useless variables

2016-04-30 Thread Andy Lutomirski
On Sat, Apr 30, 2016 at 6:24 AM, Borislav Petkov wrote: > On Mon, Apr 25, 2016 at 02:53:14PM +0800, Minfei Huang wrote: >> The value of cycles and flags can be assigned directly without >> intermediate variables. >> >> Remove the useless variables. >> >> Signed-off-by: Minfei Huang >> --- >> arc

Re: [PATCH] Cleanup __pvclock_read_cycles to remove useless variables

2016-04-30 Thread Borislav Petkov
On Mon, Apr 25, 2016 at 02:53:14PM +0800, Minfei Huang wrote: > The value of cycles and flags can be assigned directly without > intermediate variables. > > Remove the useless variables. > > Signed-off-by: Minfei Huang > --- > arch/x86/include/asm/pvclock.h | 15 --- > 1 file change

Re: [PATCH] Cleanup __pvclock_read_cycles to remove useless variables

2016-04-30 Thread Minfei Huang
ping. Any comment is appreciate. Thanks Minfei On 04/25/16 at 02:53P, Minfei Huang wrote: > The value of cycles and flags can be assigned directly without > intermediate variables. > > Remove the useless variables. > > Signed-off-by: Minfei Huang > --- > arch/x86/include/asm/pvclock.h | 15 +

[PATCH] Cleanup __pvclock_read_cycles to remove useless variables

2016-04-24 Thread Minfei Huang
The value of cycles and flags can be assigned directly without intermediate variables. Remove the useless variables. Signed-off-by: Minfei Huang --- arch/x86/include/asm/pvclock.h | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/arch/x86/include/asm/pvclock.h