Re: [PATCH] Clarify CONFIG_DEBUG_INFO's bloaty nature

2014-02-04 Thread Ingo Molnar
* Linus Torvalds wrote: > On Tue, Feb 4, 2014 at 1:08 AM, Ingo Molnar wrote: > > > > config SAVE_TIME_AND_DISK_SPACE > > bool "Faster and leaner build object files: compile without debug > > info" > > default y > > Thinking about it, we already have this. It's called "CONFIG_

Re: [PATCH] Clarify CONFIG_DEBUG_INFO's bloaty nature

2014-02-04 Thread Linus Torvalds
On Tue, Feb 4, 2014 at 9:32 AM, Andi Kleen wrote: > > I have used debug info on allyesconfig in the past to run statistics > on the resulting binary. It's still useful, even though quite slow. > Make it depend on !EXPERT or somesuch? I agree for normal usages it's fine. EXPERT is useless, people

Re: [PATCH] Clarify CONFIG_DEBUG_INFO's bloaty nature

2014-02-04 Thread Andi Kleen
Linus Torvalds writes: > > Trivial oneliner patch (independent of the discussion about improving > the documentation), so I'll just apply it. > > I can't imagine that this would be controversial: > >config DEBUG_INFO > bool "Compile the kernel with debug info" > - depends on

Re: [PATCH] Clarify CONFIG_DEBUG_INFO's bloaty nature

2014-02-04 Thread Linus Torvalds
On Tue, Feb 4, 2014 at 1:08 AM, Ingo Molnar wrote: > > config SAVE_TIME_AND_DISK_SPACE > bool "Faster and leaner build object files: compile without debug > info" > default y Thinking about it, we already have this. It's called "CONFIG_COMPILE_TEST". It very much gets set by al

Re: [PATCH] Clarify CONFIG_DEBUG_INFO's bloaty nature

2014-02-04 Thread Ingo Molnar
* David Rientjes wrote: > On Mon, 3 Feb 2014, Andrew Morton wrote: > > > > > How do you define "huge bloat" if the size of vmlinux doesn't increase? > > > > > > Don't be silly. The size of all the object files increase *hugely*. > > > > yup, I disable this in my allmodconfig testing, to great

Re: [PATCH] Clarify CONFIG_DEBUG_INFO's bloaty nature

2014-02-03 Thread Borislav Petkov
On Mon, Feb 03, 2014 at 02:57:18PM -0800, Andrew Morton wrote: > On Mon, 3 Feb 2014 14:47:15 -0800 Linus Torvalds > wrote: > > > On Mon, Feb 3, 2014 at 2:00 PM, David Rientjes wrote: > > > > > > How do you define "huge bloat" if the size of vmlinux doesn't increase? > > > > Don't be silly. The

Re: [PATCH] Clarify CONFIG_DEBUG_INFO's bloaty nature

2014-02-03 Thread David Rientjes
On Mon, 3 Feb 2014, Andrew Morton wrote: > > > How do you define "huge bloat" if the size of vmlinux doesn't increase? > > > > Don't be silly. The size of all the object files increase *hugely*. > > yup, I disable this in my allmodconfig testing, to great effect. > > That being said, I do think

Re: [PATCH] Clarify CONFIG_DEBUG_INFO's bloaty nature

2014-02-03 Thread Andrew Morton
On Mon, 3 Feb 2014 14:47:15 -0800 Linus Torvalds wrote: > On Mon, Feb 3, 2014 at 2:00 PM, David Rientjes wrote: > > > > How do you define "huge bloat" if the size of vmlinux doesn't increase? > > Don't be silly. The size of all the object files increase *hugely*. yup, I disable this in my all

Re: [PATCH] Clarify CONFIG_DEBUG_INFO's bloaty nature

2014-02-03 Thread Linus Torvalds
On Mon, Feb 3, 2014 at 2:00 PM, David Rientjes wrote: > > How do you define "huge bloat" if the size of vmlinux doesn't increase? Don't be silly. The size of all the object files increase *hugely*. This is my fs/builtin.o in my normal config: -rw-rw-r--. 1 torvalds torvalds 2838613 Feb 3 14

Re: [PATCH] Clarify CONFIG_DEBUG_INFO's bloaty nature

2014-02-03 Thread David Rientjes
On Mon, 3 Feb 2014, Borislav Petkov wrote: > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index dbf94a7d25a8..9095c2078095 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -126,7 +126,11 @@ config DEBUG_INFO > This adds debug symbols to the kernel and modules (gcc -g

[PATCH] Clarify CONFIG_DEBUG_INFO's bloaty nature

2014-02-03 Thread Borislav Petkov
From: Borislav Petkov Hold down when it makes sense to enable CONFIG_DEBUG_INFO and when CONFIG_KALLSYMS suffices. Signed-off-by: Borislav Petkov Link: http://lkml.kernel.org/r/CA%2B55aFw_xs1tUteDrXz21QZB7BFk5p%2BF5NZ-SpV=cuvjefw...@mail.gmail.com Cc: Andrew Morton Cc: Linus Torvalds --- li