Re: [PATCH] CHECK_IRQ_PER_CPU() to avoid dead code in __do_IRQ()

2005-08-09 Thread Zwane Mwaikambo
On Mon, 8 Aug 2005, Alexander Nyberg wrote: > > IRQ_PER_CPU is not used by all architectures. > > This patch introduces the macros > > ARCH_HAS_IRQ_PER_CPU and CHECK_IRQ_PER_CPU() to avoid the generation of > > dead code in __do_IRQ(). > > > > ARCH_HAS_IRQ_PER_CPU is defined by architectures usin

Re: [PATCH] CHECK_IRQ_PER_CPU() to avoid dead code in __do_IRQ()

2005-08-08 Thread Zachary Amsden
Karsten Wiese wrote: Am Montag, 8. August 2005 13:19 schrieb Alexander Nyberg: There are many places where one could replace run-time tests with #ifdef's but it makes reading more difficult (and in longer terms maintainence). Have you benchmarked any workload that benefits from this?

Re: [PATCH] CHECK_IRQ_PER_CPU() to avoid dead code in __do_IRQ()

2005-08-08 Thread Karsten Wiese
Am Montag, 8. August 2005 13:19 schrieb Alexander Nyberg: > > There are many places where one could replace run-time tests with > #ifdef's but it makes reading more difficult (and in longer terms > maintainence). Have you benchmarked any workload that benefits > from this? Performance gain is s

Re: [PATCH] CHECK_IRQ_PER_CPU() to avoid dead code in __do_IRQ()

2005-08-08 Thread Alexander Nyberg
> > IRQ_PER_CPU is not used by all architectures. > This patch introduces the macros > ARCH_HAS_IRQ_PER_CPU and CHECK_IRQ_PER_CPU() to avoid the generation of > dead code in __do_IRQ(). > > ARCH_HAS_IRQ_PER_CPU is defined by architectures using > IRQ_PER_CPU in their > include/asm_ARCH/ir

[PATCH] CHECK_IRQ_PER_CPU() to avoid dead code in __do_IRQ()

2005-08-08 Thread Karsten Wiese
Hi Ingo, This version of the patch has better coding style thanks to comments from Ingo Oeser. Please comment or pass it on as appropriate. Patch is for mainline 2.6.13-rc6. Thanks, Karsten -- From: Karsten Wiese <[EMAIL PROTECTED]> IRQ_PER_CPU is not used by all architectures. This