Re: [PATCH] Broken NR_RESERVED_FILES

2000-12-07 Thread Szabolcs Szakacsits
On Thu, 7 Dec 2000, Tigran Aivazian wrote: > On Thu, 7 Dec 2000, Szabolcs Szakacsits wrote: > > Read the whole get_empty_filp function, especially this part, note the > > goto new_one below and the part you didn't include above [from > > the new_one label], > > > > if (files_stat.nr_file

Re: [PATCH] Broken NR_RESERVED_FILES

2000-12-07 Thread Tigran Aivazian
On Thu, 7 Dec 2000, Szabolcs Szakacsits wrote: > Read the whole get_empty_filp function, especially this part, note the > goto new_one below and the part you didn't include above [from > the new_one label], > > if (files_stat.nr_files < files_stat.max_files) { > file_list_

Re: [PATCH] Broken NR_RESERVED_FILES

2000-12-07 Thread Szabolcs Szakacsits
On Thu, 7 Dec 2000, Tigran Aivazian wrote: > On Thu, 7 Dec 2000, Szabolcs Szakacsits wrote: > > again. The failed logic is also clear from the kernel code [user > > happily allocates when freelist < NR_RESERVED_FILES]. > > is it clear to you? it is not clear to me, or rather the opposite seems >

Re: [PATCH] Broken NR_RESERVED_FILES

2000-12-07 Thread Tigran Aivazian
On Thu, 7 Dec 2000, Szabolcs Szakacsits wrote: > again. The failed logic is also clear from the kernel code [user > happily allocates when freelist < NR_RESERVED_FILES]. is it clear to you? it is not clear to me, or rather the opposite seems clear. This is what the code looks like (in 2.4): stru

Re: [PATCH] Broken NR_RESERVED_FILES

2000-12-07 Thread Szabolcs Szakacsits
On Thu, 7 Dec 2000, Tigran Aivazian wrote: > On Thu, 7 Dec 2000, Szabolcs Szakacsits wrote: > > On Thu, 7 Dec 2000, Tigran Aivazian wrote: > > > On Thu, 7 Dec 2000, Szabolcs Szakacsits wrote: > > > > Reserved fd's for superuser doesn't work. > > > It does actually work, > > > > What do you mean u

Re: [PATCH] Broken NR_RESERVED_FILES

2000-12-07 Thread Tigran Aivazian
On Thu, 7 Dec 2000, Szabolcs Szakacsits wrote: > On Thu, 7 Dec 2000, Tigran Aivazian wrote: > > On Thu, 7 Dec 2000, Szabolcs Szakacsits wrote: > > > Reserved fd's for superuser doesn't work. > > It does actually work, > > What do you mean under "work"? I meant user apps are able to > exhaust fd's

Re: [PATCH] Broken NR_RESERVED_FILES

2000-12-07 Thread Szabolcs Szakacsits
On Thu, 7 Dec 2000, Tigran Aivazian wrote: > On Thu, 7 Dec 2000, Szabolcs Szakacsits wrote: > > Reserved fd's for superuser doesn't work. > It does actually work, What do you mean under "work"? I meant user apps are able to exhaust fd's completely and none is left for superuser. > but remember

Re: [PATCH] Broken NR_RESERVED_FILES

2000-12-07 Thread Tigran Aivazian
Hi, Another comment on your patch. You removed the goto used_one (probably a good idea, I hated it as well and preferred to put it into the if()) but you forgot to remove the label itself. Regards, Tigran - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH] Broken NR_RESERVED_FILES

2000-12-07 Thread Tigran Aivazian
On Thu, 7 Dec 2000, Szabolcs Szakacsits wrote: > Reserved fd's for superuser doesn't work. It does actually work, but remember that the concept of "reserved file structures for superuser" is defined as "file structures to be taken from the freelist" whereas your patch below: > + total_free =

[PATCH] Broken NR_RESERVED_FILES

2000-12-07 Thread Szabolcs Szakacsits
Reserved fd's for superuser doesn't work. Patch for 2.2 is below, kernel 2.4.x also has this problem, fix is similar. The default NR_RESERVED_FILES value also had to be increased (e.g. ssh, login needs 36, ls 16, man 45 fd's, etc). BTW, I have an updated version of my reserved VM for superuser +