Re: [PATCH] Bluetooth: hci_core: Avoid mixing up req_complete and req_complete_skb

2016-02-20 Thread Marcel Holtmann
Hi Douglas, > In commit 44d271377479 ("Bluetooth: Compress the size of struct > hci_ctrl") we squashed down the size of the structure by using a union > with the assumption that all users would use the flag to determine > whether we had a req_complete or a req_complete_skb. > > Unfortunately we h

Re: [PATCH] Bluetooth: hci_core: Avoid mixing up req_complete and req_complete_skb

2016-02-19 Thread Johan Hedberg
Hi Douglas, On Fri, Feb 19, 2016, Douglas Anderson wrote: > In commit 44d271377479 ("Bluetooth: Compress the size of struct > hci_ctrl") we squashed down the size of the structure by using a union > with the assumption that all users would use the flag to determine > whether we had a req_complete

[PATCH] Bluetooth: hci_core: Avoid mixing up req_complete and req_complete_skb

2016-02-19 Thread Douglas Anderson
In commit 44d271377479 ("Bluetooth: Compress the size of struct hci_ctrl") we squashed down the size of the structure by using a union with the assumption that all users would use the flag to determine whether we had a req_complete or a req_complete_skb. Unfortunately we had a case in hci_req_cmd_