Re: [PATCH] Avoid time_offset overflows

2007-03-25 Thread Thomas Gleixner
On Sun, 2007-03-25 at 01:09 -0800, Andrew Morton wrote: > On Sat, 24 Mar 2007 06:20:45 +0100 (CET) Roman Zippel <[EMAIL PROTECTED]> > wrote: > > > Hi, > > > > On Fri, 23 Mar 2007, john stultz wrote: > > > > > @@ -314,8 +314,8 @@ #endif > > > freq_adj += time_freq; > > >

Re: [PATCH] Avoid time_offset overflows

2007-03-25 Thread Andrew Morton
On Sat, 24 Mar 2007 06:20:45 +0100 (CET) Roman Zippel <[EMAIL PROTECTED]> wrote: > Hi, > > On Fri, 23 Mar 2007, john stultz wrote: > > > @@ -314,8 +314,8 @@ #endif > > freq_adj += time_freq; > > freq_adj = min(freq_adj, (s64)MAXFREQ_NSEC); > > time

Re: [PATCH] Avoid time_offset overflows

2007-03-23 Thread Roman Zippel
Hi, On Fri, 23 Mar 2007, john stultz wrote: > @@ -314,8 +314,8 @@ #endif > freq_adj += time_freq; > freq_adj = min(freq_adj, (s64)MAXFREQ_NSEC); > time_freq = max(freq_adj, (s64)-MAXFREQ_NSEC); > - time_offset = (time_offset /

[PATCH] Avoid time_offset overflows

2007-03-23 Thread john stultz
I've been seeing some odd NTP behavior recently on a few boxes and finally narrowed it down to time_offset overflowing when converted to SHIFT_UPDATE units (which was a side effect from my HZfreeNTP patch). This patch converts time_offset from a long to a s64 which resolves the issue. thanks -joh