Re: [PATCH] Adding a support for Skyworks SKY81452

2014-08-08 Thread Tobias Klauser
On 2014-08-08 at 09:09:19 +0200, Thierry Reding wrote: > On Thu, Aug 07, 2014 at 02:34:39PM +0200, Tobias Klauser wrote: > > On 2014-08-07 at 10:05:38 +0200, Gyungoh Yoo wrote: > [...] > > > +#ifdef CONFIG_OF > > > +static const struct of_device_id sky81452_of_match[] = { > > > + {.compatible =

Re: [PATCH] Adding a support for Skyworks SKY81452

2014-08-08 Thread Thierry Reding
On Thu, Aug 07, 2014 at 02:34:39PM +0200, Tobias Klauser wrote: > On 2014-08-07 at 10:05:38 +0200, Gyungoh Yoo wrote: [...] > > +#ifdef CONFIG_OF > > +static const struct of_device_id sky81452_of_match[] = { > > + {.compatible = "sky,sky81452",}, > > + { } > > +}; > > +MODULE_DEVICE_TABLE(of,

Re: [PATCH] Adding a support for Skyworks SKY81452

2014-08-07 Thread Gyungoh Yoo
Thank you for your comments. I will fix them and resubmit. On Thu, Aug 07, 2014 at 02:34:39PM +0200, Tobias Klauser wrote: > On 2014-08-07 at 10:05:38 +0200, Gyungoh Yoo wrote: > > Signed-off-by: Gyungoh Yoo > > --- > > Documentation/backlight/sky81452.txt | 25 ++ > > Documentat

Re: [PATCH] Adding a support for Skyworks SKY81452

2014-08-07 Thread Gyungoh Yoo
On Thu, Aug 07, 2014 at 11:09:52AM +0100, Lee Jones wrote: > On Thu, 07 Aug 2014, Gyungoh Yoo wrote: > > > Signed-off-by: Gyungoh Yoo > > --- > > Documentation/backlight/sky81452.txt | 25 ++ > > Documentation/devicetree/bindings/mfd/sky81452.txt | 24 ++ > > .../bindings/regulat

Re: [PATCH] Adding a support for Skyworks SKY81452

2014-08-07 Thread Tobias Klauser
On 2014-08-07 at 10:05:38 +0200, Gyungoh Yoo wrote: > Signed-off-by: Gyungoh Yoo > --- > Documentation/backlight/sky81452.txt | 25 ++ > Documentation/devicetree/bindings/mfd/sky81452.txt | 24 ++ > .../bindings/regulator/sky81452-regulator.txt | 16 + > .../devicetree/bind

Re: [PATCH] Adding a support for Skyworks SKY81452

2014-08-07 Thread Lee Jones
On Thu, 07 Aug 2014, Gyungoh Yoo wrote: > Signed-off-by: Gyungoh Yoo > --- > Documentation/backlight/sky81452.txt | 25 ++ > Documentation/devicetree/bindings/mfd/sky81452.txt | 24 ++ > .../bindings/regulator/sky81452-regulator.txt | 16 + > .../devicetree/bindings/vendor-

[PATCH] Adding a support for Skyworks SKY81452

2014-08-07 Thread Gyungoh Yoo
Signed-off-by: Gyungoh Yoo --- Documentation/backlight/sky81452.txt | 25 ++ Documentation/devicetree/bindings/mfd/sky81452.txt | 24 ++ .../bindings/regulator/sky81452-regulator.txt | 16 + .../devicetree/bindings/vendor-prefixes.txt| 1 + .../video/backlight/sky8