Re: [PATCH] Add the memcg print oom info for system oom

2018-05-22 Thread David Rientjes
On Tue, 22 May 2018, Michal Hocko wrote: > > I've had success with defining a single line output the includes the > > CONSTRAINT_* of the oom kill, the origin and kill memcgs, the thread name, > > pid, and uid. On system oom kills, origin and kill memcgs are left empty. > > > > oom-kill constr

Re: [PATCH] Add the memcg print oom info for system oom

2018-05-21 Thread Michal Hocko
On Mon 21-05-18 14:11:21, David Rientjes wrote: > On Thu, 17 May 2018, Michal Hocko wrote: > > > this is not 5 lines at all. We dump memcg stats for the whole oom memcg > > subtree. For your patch it would be the whole subtree of the memcg of > > the oom victim. With cgroup v1 this can be quite de

Re: [PATCH] Add the memcg print oom info for system oom

2018-05-21 Thread David Rientjes
On Thu, 17 May 2018, Michal Hocko wrote: > this is not 5 lines at all. We dump memcg stats for the whole oom memcg > subtree. For your patch it would be the whole subtree of the memcg of > the oom victim. With cgroup v1 this can be quite deep as tasks can > belong to inter-nodes as well. Would be

Re: [PATCH] Add the memcg print oom info for system oom

2018-05-19 Thread kbuild test robot
Hi yuzhoujian, Thank you for the patch! Yet something to improve: [auto build test ERROR on mmotm/master] [also build test ERROR on v4.17-rc5 next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/lin

Re: [PATCH] Add the memcg print oom info for system oom

2018-05-17 Thread Roman Gushchin
On Thu, May 17, 2018 at 12:23:30PM +0200, Michal Hocko wrote: > On Thu 17-05-18 17:44:43, 禹舟键 wrote: > > Hi Michal > > I think the current OOM report is imcomplete. I can get the task which > > invoked the oom-killer and the task which has been killed by the > > oom-killer, and memory info when the

Re: [PATCH] Add the memcg print oom info for system oom

2018-05-17 Thread Michal Hocko
On Thu 17-05-18 17:44:43, 禹舟键 wrote: > Hi Michal > I think the current OOM report is imcomplete. I can get the task which > invoked the oom-killer and the task which has been killed by the > oom-killer, and memory info when the oom happened. But I cannot infer the > certain memcg to which the task

Re: [PATCH] Add the memcg print oom info for system oom

2018-05-17 Thread Michal Hocko
On Thu 17-05-18 08:00:28, ufo19890607 wrote: > From: yuzhoujian > > The dump_header does not print the memcg's name when the system > oom happened. Some users want to locate the certain container > which contains the task that has been killed by the oom killer. > So I add the mem_cgroup_print_oom

[PATCH] Add the memcg print oom info for system oom

2018-05-17 Thread ufo19890607
From: yuzhoujian The dump_header does not print the memcg's name when the system oom happened. Some users want to locate the certain container which contains the task that has been killed by the oom killer. So I add the mem_cgroup_print_oom_info when system oom events happened. Signed-off-by: yu