Re: [PATCH] Add support for keyboard on SEGA Dreamcast

2007-09-07 Thread Adrian McMenamin
On 05/09/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > > Are we guaranteed that the dc_kbd_callback is not running in a separate > thread? > > Please also consider implementing support for changing keyma. Since > the keymap is pretty full I think the best way is to copy the vanilla > keymap int

Re: [PATCH] Add support for keyboard on SEGA Dreamcast

2007-09-04 Thread Dmitry Torokhov
Hi Mike, On Wednesday 05 September 2007 00:34, Mike Frysinger wrote: > > + kbd->dev = input_allocate_device(); > > ... > > + retval = input_register_device(kbd->dev); > > + if (unlikely(retval)) > > + goto cleanup; > > ... > > +      cleanup: > > + kfree(kbd); > > +

Re: [PATCH] Add support for keyboard on SEGA Dreamcast

2007-09-04 Thread Mike Frysinger
On Tuesday 04 September 2007, Adrian McMenamin wrote: > --- a/drivers/input/keyboard/Kconfig > +++ b/drivers/input/keyboard/Kconfig > + Say Y here if you have a DreamCast console running Linux and have funny caps in Dreamcast > --- /dev/null > +++ b/drivers/input/keyboard/maple_keyb.c > +st

Re: [PATCH] Add support for keyboard on SEGA Dreamcast

2007-09-04 Thread Dmitry Torokhov
Hi Adrian, On Tuesday 04 September 2007 19:34, Adrian McMenamin wrote: > This patch will add support for the Dreamcast keyboard when used > alongside the maple bus patch (http://lkml.org/lkml/2007/9/4/165) and > the pvr2 patch. > > Signed off by: Adrian McMenamin <[EMAIL PROTECTED]> > Thnank you

[PATCH] Add support for keyboard on SEGA Dreamcast

2007-09-04 Thread Adrian McMenamin
This patch will add support for the Dreamcast keyboard when used alongside the maple bus patch (http://lkml.org/lkml/2007/9/4/165) and the pvr2 patch. Signed off by: Adrian McMenamin <[EMAIL PROTECTED]> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index c97d5eb..16