Re: [PATCH] Add possibility to define bits-per-word property.

2017-02-17 Thread Mark Brown
On Thu, Feb 16, 2017 at 02:39:10PM +0100, Adrian Fiergolski wrote: > Signed-off-by: Adrian Fiergolski > --- > drivers/spi/spi.c | 17 + > 1 file changed, 17 insertions(+) Why would this property be useful? You're also adding a new binding with no binding documentation, binding d

Re: [PATCH] Add possibility to define bits-per-word property.

2017-02-17 Thread Miguel Ojeda
Hi Adrian, Please review the style to match the kernel's (and the rest of the code in the file). See an example below and https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst (I have no idea regarding the functional changes on this patch, I just noticed the email c

[PATCH] Add possibility to define bits-per-word property.

2017-02-16 Thread Adrian Fiergolski
Signed-off-by: Adrian Fiergolski --- drivers/spi/spi.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 0239b45..d2267e9 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1549,6 +1549,17 @@ of_register_spi_device(struct sp