Re: [PATCH] Add missing newlines to some uses of dev_ messages

2007-08-11 Thread David Brownell
On Saturday 11 August 2007, Jean Delvare wrote: > Note that there are 3 more messages to fix in > drivers/i2c/chips/menelaus.c (3 calls to pr_err.) I'd hope those will get fixed by final versions of the patches I've seen floating around definining a standard pr_err() ... not fixing them here allow

Re: [PATCH] Add missing newlines to some uses of dev_ messages

2007-08-11 Thread Jean Delvare
Hi Joe, On Tue, 07 Aug 2007 18:09:39 -0700, Joe Perches wrote: > Found these while looking at printk uses. > > Add missing newlines to dev_ uses > Add missing KERN_ prefixes to multiline dev_s > Fixed a wierd->weird spelling typo > Added a newline to a printk Thanks for doing this. > diff --git

Re: [PATCH] Add missing newlines to some uses of dev_ messages

2007-08-10 Thread Jean Delvare
Hi Nish, On Tue, 7 Aug 2007 20:00:24 -0700, Nish Aravamudan wrote: > On 8/7/07, Joe Perches <[EMAIL PROTECTED]> wrote: > > Found these while looking at printk uses. > > > > Add missing newlines to dev_ uses > > Add missing KERN_ prefixes to multiline dev_s > > Fixed a wierd->weird spelling typo >

Re: [PATCH] Add missing newlines to some uses of dev_ messages

2007-08-08 Thread Jiri Slaby
Joe Perches napsal(a): > Found these while looking at printk uses. > > Add missing newlines to dev_ uses > Add missing KERN_ prefixes to multiline dev_s > Fixed a wierd->weird spelling typo > Added a newline to a printk > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > drivers/char/isicom.

Re: [PATCH] Add missing newlines to some uses of dev_ messages

2007-08-08 Thread David Brownell
Splitting by subsystem *would* have been better ... On Tuesday 07 August 2007, Joe Perches wrote: >  drivers/i2c/chips/menelaus.c           |    2 +- ok ... >  drivers/net/usb/mcs7830.c              |   16 +++--- ... ok ... >  drivers/rtc/rtc-sysfs.c                |    5 +-- ... ok .

Re: [PATCH] Add missing newlines to some uses of dev_ messages

2007-08-08 Thread Mark M. Hoffman
* Joe Perches <[EMAIL PROTECTED]> [2007-08-07 18:09:39 -0700]: > Found these while looking at printk uses. > > Add missing newlines to dev_ uses > Add missing KERN_ prefixes to multiline dev_s > Fixed a wierd->weird spelling typo > Added a newline to a printk > > Signed-off-by: Joe Perches <[EMA

Re: [PATCH] Add missing newlines to some uses of dev_ messages

2007-08-07 Thread Nish Aravamudan
On 8/7/07, Joe Perches <[EMAIL PROTECTED]> wrote: > Found these while looking at printk uses. > > Add missing newlines to dev_ uses > Add missing KERN_ prefixes to multiline dev_s > Fixed a wierd->weird spelling typo > Added a newline to a printk I think these should have been split logically into

Re: [PATCH] Add missing newlines to some uses of dev_ messages

2007-08-07 Thread Jeff Garzik
James Smart wrote: ACK -- james s Joe Perches wrote: [...] Standard email etiquette: please don't quote the entirety of a 1200+ line patch, just for a one-line response. (also, top posting should be avoided as well) - To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCH] Add missing newlines to some uses of dev_ messages

2007-08-07 Thread James Smart
ACK -- james s Joe Perches wrote: Found these while looking at printk uses. Add missing newlines to dev_ uses Add missing KERN_ prefixes to multiline dev_s Fixed a wierd->weird spelling typo Added a newline to a printk Signed-off-by: Joe Perches <[EMAIL PROTECTED]> arch/ia64/sn/kernel/xpne

[PATCH] Add missing newlines to some uses of dev_ messages

2007-08-07 Thread Joe Perches
Found these while looking at printk uses. Add missing newlines to dev_ uses Add missing KERN_ prefixes to multiline dev_s Fixed a wierd->weird spelling typo Added a newline to a printk Signed-off-by: Joe Perches <[EMAIL PROTECTED]> arch/ia64/sn/kernel/xpnet.c| 13 ++- dri