Re: [PATCH] Add Second Fan Support for Thinkpad P50

2018-04-04 Thread Alexander Kappner
Andy: Thanks for pushing, and for the pointers regarding formalities; I'll keep those in mind. Also, it would be great if someone could test the fan reporting on a P70 Thinkpad (which has the same fan configuration as my P50 and thus likely needs the same quirk). Best Alexander Kappner > On

Re: [PATCH] Add Second Fan Support for Thinkpad P50

2018-04-03 Thread Andy Shevchenko
On Mon, Apr 2, 2018 at 9:27 PM, Alexander Kappner wrote: > The Thinkpad P50 has 2 fans. Add the 2FAN quirk so the tpacpi driver > properly reports both fan speeds. > Because the P50 doesn't report the version of its EC controller, we need to > identify it by BIOS version (N1). I have pushed it wi

Re: [ibm-acpi-devel] [PATCH] Add Second Fan Support for Thinkpad P50

2018-04-02 Thread Alexander Kappner
Yes, I tested this successfully on my P50 (see below). Thanks for Ack'ing. ak@REDDOT:~$ sensors thinkpad-isa- Adapter: ISA adapter fan1:3778 RPM fan2:3771 RPM ... On 04/02/2018 01:22 PM, Andy Shevchenko wrote: > I would rather name it ..._QB() instead > > Better of course

Re: [PATCH] Add Second Fan Support for Thinkpad P50

2018-04-02 Thread Andy Shevchenko
On Mon, Apr 2, 2018 at 9:27 PM, Alexander Kappner wrote: > The Thinkpad P50 has 2 fans. Add the 2FAN quirk so the tpacpi driver > properly reports both fan speeds. > Because the P50 doesn't report the version of its EC controller, we need to > identify it by BIOS version (N1). > > Signed-off-by: A

Re: [PATCH] Add Second Fan Support for Thinkpad P50

2018-04-02 Thread Henrique de Moraes Holschuh
On Mon, 02 Apr 2018, Alexander Kappner wrote: > The Thinkpad P50 has 2 fans. Add the 2FAN quirk so the tpacpi driver > properly reports both fan speeds. > Because the P50 doesn't report the version of its EC controller, we need to > identify it by BIOS version (N1). > > Signed-off-by: Alexander Ka

[PATCH] Add Second Fan Support for Thinkpad P50

2018-04-02 Thread Alexander Kappner
The Thinkpad P50 has 2 fans. Add the 2FAN quirk so the tpacpi driver properly reports both fan speeds. Because the P50 doesn't report the version of its EC controller, we need to identify it by BIOS version (N1). Signed-off-by: Alexander Kappner --- drivers/platform/x86/thinkpad_acpi.c | 8 +