Re: [PATCH] Add MCE resume under ia32

2005-08-25 Thread Pavel Machek
On Čt 25-08-05 10:36:31, Shaohua Li wrote: > On Wed, 2005-08-24 at 10:50 +0200, Pavel Machek wrote: > > Hi! > > > > > > > diff -puN arch/i386/power/cpu.c~mcheck_resume arch/i386/power/cpu.c > > > > > --- linux-2.6.13-rc6/arch/i386/power/cpu.c~mcheck_resume > > > > > 2005-08-23 09:32:13.05400

Re: [PATCH] Add MCE resume under ia32

2005-08-24 Thread Shaohua Li
On Wed, 2005-08-24 at 10:50 +0200, Pavel Machek wrote: > Hi! > > > > > diff -puN arch/i386/power/cpu.c~mcheck_resume arch/i386/power/cpu.c > > > > --- linux-2.6.13-rc6/arch/i386/power/cpu.c~mcheck_resume > > > > 2005-08-23 09:32:13.054008584 +0800 > > > > +++ linux-2.6.13-rc6-root/arch/i38

Re: [PATCH] Add MCE resume under ia32

2005-08-24 Thread Pavel Machek
Hi! > > > The boot code already initialized MCE for APs, it isn't required to > > > initialize again. The MCE entries are cpuhotplug friendly, so for > > > suspend/resume. > > > > Ok so you're saying the only change needed is to remove > > the on_each_cpu() in the resume method? Fine I can do tha

Re: [PATCH] Add MCE resume under ia32

2005-08-24 Thread Pavel Machek
Hi! > > > diff -puN arch/i386/power/cpu.c~mcheck_resume arch/i386/power/cpu.c > > > --- linux-2.6.13-rc6/arch/i386/power/cpu.c~mcheck_resume 2005-08-23 > > > 09:32:13.054008584 +0800 > > > +++ linux-2.6.13-rc6-root/arch/i386/power/cpu.c 2005-08-23 > > > 09:41:54.992540480 +0800 > > > @@ -104,

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Shaohua Li
On Wed, 2005-08-24 at 06:26 +0200, Andi Kleen wrote: > On Wednesday 24 August 2005 06:16, Shaohua Li wrote: > > > The boot code already initialized MCE for APs, it isn't required to > > initialize again. The MCE entries are cpuhotplug friendly, so for > > suspend/resume. > > Ok so you're saying t

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Andi Kleen
On Wednesday 24 August 2005 06:16, Shaohua Li wrote: > The boot code already initialized MCE for APs, it isn't required to > initialize again. The MCE entries are cpuhotplug friendly, so for > suspend/resume. Ok so you're saying the only change needed is to remove the on_each_cpu() in the resume

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Shaohua Li
On Wed, 2005-08-24 at 05:59 +0200, Andi Kleen wrote: > [adding discuss to cc] > > On Wednesday 24 August 2005 05:47, Shaohua Li wrote: > > On Wed, 2005-08-24 at 05:12 +0200, Andi Kleen wrote: > > > On Wednesday 24 August 2005 03:59, Shaohua Li wrote: > > > > On Wed, 2005-08-24 at 03:52 +0200, Andi

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Andi Kleen
[adding discuss to cc] On Wednesday 24 August 2005 05:47, Shaohua Li wrote: > On Wed, 2005-08-24 at 05:12 +0200, Andi Kleen wrote: > > On Wednesday 24 August 2005 03:59, Shaohua Li wrote: > > > On Wed, 2005-08-24 at 03:52 +0200, Andi Kleen wrote: > > > > Shaohua Li <[EMAIL PROTECTED]> writes: > >

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Shaohua Li
On Wed, 2005-08-24 at 05:12 +0200, Andi Kleen wrote: > On Wednesday 24 August 2005 03:59, Shaohua Li wrote: > > On Wed, 2005-08-24 at 03:52 +0200, Andi Kleen wrote: > > > Shaohua Li <[EMAIL PROTECTED]> writes: > > > > x86-64 has resume support. It uses 'on_each_cpu' in resume method, > > > > which

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Andi Kleen
On Wednesday 24 August 2005 03:59, Shaohua Li wrote: > On Wed, 2005-08-24 at 03:52 +0200, Andi Kleen wrote: > > Shaohua Li <[EMAIL PROTECTED]> writes: > > > x86-64 has resume support. It uses 'on_each_cpu' in resume method, > > > which is known broken. We'd better fix it. > > > > What is broken wit

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Shaohua Li
On Wed, 2005-08-24 at 03:52 +0200, Andi Kleen wrote: > Shaohua Li <[EMAIL PROTECTED]> writes: > > > x86-64 has resume support. It uses 'on_each_cpu' in resume method, which > > is known broken. We'd better fix it. > > What is broken with it? It's a sysdev. The resume method is invoked with inter

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Andi Kleen
Shaohua Li <[EMAIL PROTECTED]> writes: > x86-64 has resume support. It uses 'on_each_cpu' in resume method, which > is known broken. We'd better fix it. What is broken with it? -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PRO

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Shaohua Li
On Tue, 2005-08-23 at 12:32 +0200, Pavel Machek wrote: > > It's widely seen a MCE non-fatal error reported after resume. It seems > > MCE resume is lacked under ia32. This patch tries to fix the gap. > > Well, you patch seems like missing piece of puzzle, but: > > a) we probably want to do it for

Re: [PATCH] Add MCE resume under ia32

2005-08-23 Thread Pavel Machek
Hi! > It's widely seen a MCE non-fatal error reported after resume. It seems > MCE resume is lacked under ia32. This patch tries to fix the gap. Well, you patch seems like missing piece of puzzle, but: a) we probably want to do it for x86-64, too, and b) > diff -puN arch/i386/power/cpu.c~mche

[PATCH] Add MCE resume under ia32

2005-08-22 Thread Shaohua Li
Hi, It's widely seen a MCE non-fatal error reported after resume. It seems MCE resume is lacked under ia32. This patch tries to fix the gap. Signed-off-by: Shaohua Li<[EMAIL PROTECTED]> --- linux-2.6.13-rc6-root/arch/i386/kernel/cpu/mcheck/k7.c |2 +- linux-2.6.13-rc6-root/arch/i386/ke