Re: [PATCH] Add ELF note with Linux version

2007-09-14 Thread Roland McGrath
> Yes, binutils can be pretty fragile with notes about. In this case it > seems to be a specific problem with build-id; I'm not really sure what > build-id actually does. The thing about the build ID section that brings up issues with linking is that it is a SHF_ALLOC, SHT_NOTE section. As you m

Re: [PATCH] Add ELF note with Linux version

2007-09-14 Thread Jeremy Fitzhardinge
Sam Ravnborg wrote: >>> This seems outright silly. >>> Either we should revert the notes changes or someone caring about it >>> should sweep all archs and make sure it does not hurt there. >>> >> Hm, sounds like yet another binutils bug; unfortunately common when ELF >> notes are about. Wa

Re: [PATCH] Add ELF note with Linux version

2007-09-14 Thread Roland McGrath
The right fix for the linker script is to use the NOTES macro after RODATA. I'm pretty sure this has been posted before. Each arch's vmlinux.lds.S needs that change, but the details vary if it uses an explicit PHDRS. Thanks, Roland - To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH] Add ELF note with Linux version

2007-09-14 Thread Sam Ravnborg
> > This seems outright silly. > > Either we should revert the notes changes or someone caring about it > > should sweep all archs and make sure it does not hurt there. > > Hm, sounds like yet another binutils bug; unfortunately common when ELF > notes are about. Was there any further effort to

Re: [PATCH] Add ELF note with Linux version

2007-09-14 Thread Jeremy Fitzhardinge
Bernhard Walle wrote: > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> [2007-09-13 23:56]: > >>> I'd like to know a little bit more about why this is needed, how it will be >>> used, etc. And given that this feature is intended to improve life for >>> distributors, it would be nice to get some feedb

Re: [PATCH] Add ELF note with Linux version

2007-09-14 Thread Jeremy Fitzhardinge
Sam Ravnborg wrote: > On Thu, Sep 13, 2007 at 03:44:13PM -0700, Jeremy Fitzhardinge wrote: > >> It was originally there to put ELF notes into the vdso objects. I'm >> using it to create notes in vmlinux for Xen, and apparently people are >> using it to put other metadata into their kernel image

Re: [PATCH] Add ELF note with Linux version

2007-09-14 Thread Bernhard Walle
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> [2007-09-13 23:56]: > > > I'd like to know a little bit more about why this is needed, how it will be > > used, etc. And given that this feature is intended to improve life for > > distributors, it would be nice to get some feedback from the appropriate >

Re: [PATCH] Add ELF note with Linux version

2007-09-13 Thread Sam Ravnborg
On Thu, Sep 13, 2007 at 03:44:13PM -0700, Jeremy Fitzhardinge wrote: > Sam Ravnborg wrote: > > I would rather see allt this ELFNOTE stuff reverted. > > It causes troubles for several archs and is at the moment > > being discussed at arm-kernel for example. > > > > Having it reverted and then applie

Re: [PATCH] Add ELF note with Linux version

2007-09-13 Thread Jeremy Fitzhardinge
Sam Ravnborg wrote: > I would rather see allt this ELFNOTE stuff reverted. > It causes troubles for several archs and is at the moment > being discussed at arm-kernel for example. > > Having it reverted and then applied when it is ready for all archs would > be preferred. > What problems does i

Re: [PATCH] Add ELF note with Linux version

2007-09-13 Thread Sam Ravnborg
On Thu, Sep 13, 2007 at 02:42:28PM -0700, Andrew Morton wrote: > On Thu, 06 Sep 2007 11:36:21 +0100 > Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > > Bernhard Walle wrote: > > > This patch adds version information to the ELF kernel file. Together > > > with the bzImage version information, th

Re: [PATCH] Add ELF note with Linux version

2007-09-13 Thread Jeremy Fitzhardinge
Andrew Morton wrote: > On Thu, 06 Sep 2007 11:36:21 +0100 > Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > >> Bernhard Walle wrote: >> >>> This patch adds version information to the ELF kernel file. Together >>> with the bzImage version information, this allows distributions to >>> iden

Re: [PATCH] Add ELF note with Linux version

2007-09-13 Thread Andrew Morton
On Thu, 06 Sep 2007 11:36:21 +0100 Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Bernhard Walle wrote: > > This patch adds version information to the ELF kernel file. Together > > with the bzImage version information, this allows distributions to > > identify the kernel version based on the fil

Re: [PATCH] Add ELF note with Linux version

2007-09-06 Thread Jeremy Fitzhardinge
Bernhard Walle wrote: > This patch adds version information to the ELF kernel file. Together > with the bzImage version information, this allows distributions to > identify the kernel version based on the file name. > Seems reasonable to me, but I think the macro could be just called "ELFNOTE".

[PATCH] Add ELF note with Linux version

2007-09-04 Thread Bernhard Walle
This patch adds version information to the ELF kernel file. Together with the bzImage version information, this allows distributions to identify the kernel version based on the file name. Signed-off-by: Dan Aloni <[EMAIL PROTECTED]> Signed-off-by: Bernhard Walle <[EMAIL PROTECTED]> --- include/